-
Notifications
You must be signed in to change notification settings - Fork 3k
OLIMEX_STM32E407_F407ZG: Added new target platform #11648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rohfle, thank you for your changes. |
targets/targets.json
Outdated
"release_versions": ["5"], | ||
"device_name": "STM32F407ZG", | ||
"target_overrides": { | ||
"*": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That config doesn't belong to the target definition, please move it to platform/mbed_lib.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the target override for stdio baud rate as requested - the first two lines (release_versions, device_name) match other entries so I guess they are fine?
@@ -226,7 +227,9 @@ void USBPhyHw::init(USBPhyEvents *events) | |||
pin_function(PA_9, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, GPIO_AF10_OTG_FS)); // VBUS | |||
#endif | |||
pin_function(PA_10, STM_PIN_DATA(STM_MODE_AF_OD, GPIO_PULLUP, GPIO_AF10_OTG_FS)); // ID | |||
#if !defined(TARGET_OLIMEX_STME407_F407ZG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeromecoutant how does that fit with your usb rework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
But you're right, I should push some first commit for usb rework in order to simplify new target addtion like this.
Added Olimex STM32-E407 (STM32F407ZG) evaluation board. USB, UART, External HS XTAL and Ethernet are all working correctly.
fe66258
to
02df759
Compare
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
One of jobs failed due jenkins, restarting |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
CI restarted. I've noticed a commit was added, @rohfle still working on this branch or all done? |
@0xc0170 Not working on this branch currently - just fixing some things that were failing in CI. |
Test run: FAILEDSummary: 2 of 4 test jobs failed Failed test jobs:
|
Restarted CI, Jenkins was restarted |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Description
Added Olimex STM32-E407 (STM32F407ZG) evaluation board as target.
USB, UART, External HS XTAL (12MHz) and Ethernet are all working correctly.
Overview
/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F407xG/TARGET_OLIMEX_STM32E407_F407ZG/PinNames.h
features/netsocket/emac-drivers/TARGET_STM_EMAC/
targets/targets.json
for the boardtargets/targets.json
Testing
Followed instructions here: https://os.mbed.com/docs/mbed-os/v5.14/porting/manual-testing.html#creating-GDB-pyOCD-debug-configuration
Pull request type
Reviewers
Release Notes
Added Olimex STM32-E407 (STM32F407ZG) evaluation board as target.