Update CMSIS pack index json for STM32H7xx family #11709

JanneKiiskila · 2019-10-18T11:13:12Z

Description

Manually replaced the existing STM32H7 section and replaced it with the
context of updated index.json that pulled in the Keil packs available
today, as of 18th October, 2019.

See related PR; #11707

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 @ARMmbed/team-st-mcd @jeromecoutant

Release Notes

CMSIS pack index updated for STM32H7xx -family.

0xc0170

Becoming hard to review (file too large), I got one unicorn earlier today for this file 🙄

jeromecoutant · 2019-10-18T11:37:02Z

Hi
Could you explain which command you made to get this new file ?

jeromecoutant · 2019-10-18T14:55:16Z

tools/arm_pack_manager/index.json

+                "access": {
+                    "execute": true, 
+                    "non_secure": false, 
+


Can you remove IROM2 part for H743, and double IROM1 size?
as it is a single core, and full ROM can be used.

jeromecoutant · 2019-10-18T15:02:47Z

tools/arm_pack_manager/index.json

+                "access": {
+                    "execute": true, 
+                    "non_secure": false, 
+


How can we rename IROM1 into IROM_CM7 ?
and IROM2 into IROM_CM4 ?

JanneKiiskila · 2019-10-28T12:05:31Z

@jeromecoutant - for the modifications here - all the information is coming from the cmsis-pack you have supplied to KEIL. Nothing is generated manually and if we start changing things manually, it means we must maintain this file manually forever. Which might or might not be something we really want. @jeromecoutant - in an ideal world, STM would re-generate the STM file, after which I would re-generate the CMSIS-pack to match.

@MarceloSalazar @mark-edgeworth @bulislaw @kjbracey-arm @madchutney - we really need to think what exactly we need and where, as it seems to me have lots of duplicate information. Flash sectors and sizes are in the cmsis-packs (in this PR) AND the target files. Either one of them is a duplicate. We have some similar information also in the compiler linker/scatter files, too.

Also, having one 13 MB JSON file also does not sound like a feasible plan going into the future, we should consider splitting the file into vendor parts (if we truly even need that one .JSON file) - too large files become unmanageable/hard to review.

mark-edgeworth · 2019-10-28T15:19:01Z

@JanneKiiskila: @ARMmbed/mbed-os-tools are looking at this right now...

0xc0170 · 2019-10-29T12:44:46Z

@jeromecoutant - for the modifications here - all the information is coming from the cmsis-pack you have supplied to KEIL. Nothing is generated manually and if we start changing things manually, it means we must maintain this file manually forever. Which might or might not be something we really want. @jeromecoutant - in an ideal world, STM would re-generate the STM file, after which I would re-generate the CMSIS-pack to match.

@jeromecoutant can you rereview? As data in this PR are coming from the pack, can we use these and once pack is fixed, it will be fixed as well.

We would like to have this update on master as soon as possible.

Also, having one 13 MB JSON file also does not sound like a feasible plan going into the future, we should consider splitting the file into vendor parts (if we truly even need that one .JSON file) - too large files become unmanageable/hard to review.

Separation should help here, it will just grow in size day-by-day.

0xc0170 · 2019-10-29T12:51:43Z

@MarceloSalazar @mark-edgeworth @bulislaw @kjbracey-arm @madchutney - we really need to think what exactly we need and where, as it seems to me have lots of duplicate information. Flash sectors and sizes are in the cmsis-packs (in this PR) AND the target files. Either one of them is a duplicate. We have some similar information also in the compiler linker/scatter files, too.

I don't think these are duplicates. Not all drivers provide memory layout in the driver itself like the reference above (they could but there is no way we could get it writing one script without changes per each target family and its SDK). This information is in the cmsis packs - what we use, also what other tools use. This is standardized way to get this data.

Regarding linker scripts - this is one of the things we would like to have - one linker file per toolchain and generate it per target.

0xc0170 · 2019-10-31T15:19:29Z

Travis reports the device name is not valid:

E           AssertionError: Target DISCO_H747I contains invalid device_name STM32H747XIH6

JanneKiiskila · 2019-11-01T11:16:24Z

Oh yes, the device name for DISCO_H747I was still wrong - it's not STM32H747XIH6 but actually STM32H747AGIx (I presume). @ARMmbed/team-st-mcd - please review.

On the other hand, I'd like to get this one merged in pretty soon - the problem is that the index.json file is now so large, that if a merge conflict happens -> doing a merge for example with P4Merge seems to be near impossible now, as it just goes into non-responsive mode. Seems we've hit some kind of file limit for that application...

targets/targets.json

Manually replaced the existing STM32H7 section and replaced it with the context of updated `index.json` that pulled in the Keil packs available today, as of 18th October, 2019. See related PR; ARMmbed#11707

Compilation of bootloader requires these parameters.

Add definitions for H743ZI2, required by bootloader.

The proposed review fixes by Jerome, cherry-picked in. (cherry picked from commit fb15f02) Signed-off-by: Janne Kiiskila <[email protected]>

jeromecoutant · 2019-11-05T09:13:46Z

targets/targets.json

+        "mbed_rom_start": "0x08000000",
+        "mbed_rom_size" : "0x200000",


I am sorry, but in order to remove warnings,
we should also add (for both H743ZI and ZI2):
"mbed_ram_start": "0x24000000",
"mbed_ram_size" : "0x80000",

Which warnings? I don't recall seeing any?

Done, anyways.

Adding the RAM definitions per request of Jerome Coutant.

0xc0170 · 2019-11-05T09:43:48Z

CI started

mbed-ci · 2019-11-05T10:46:19Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

JanneKiiskila · 2019-11-05T11:38:08Z

Failure seems to be related to exporter tests;

12:33:22 [2019-11-05T10:33:22.164Z] [EXAMPLES]> ERROR FAILURE building mbed-os-example-blinky K64F make_armc6

0xc0170 · 2019-11-05T11:48:48Z

License error, restarting exporters

JanneKiiskila mentioned this pull request Oct 18, 2019

CMSIS pack update 2019-10-18 #11707

Closed

0xc0170 approved these changes Oct 18, 2019

View reviewed changes

jeromecoutant reviewed Oct 18, 2019

View reviewed changes

0xc0170 added the needs: work label Oct 21, 2019

JanneKiiskila force-pushed the CMSIS-STM32H7xx branch from 6325b3c to 652a00d Compare October 31, 2019 12:57

JanneKiiskila force-pushed the CMSIS-STM32H7xx branch from 652a00d to 3f8c9e6 Compare November 1, 2019 11:14

jeromecoutant suggested changes Nov 4, 2019

View reviewed changes

targets/targets.json Outdated Show resolved Hide resolved

targets/targets.json Show resolved Hide resolved

targets/targets.json Outdated Show resolved Hide resolved

jeromecoutant mentioned this pull request Nov 4, 2019

DISCO_H747I - device_name missing in targets.json #11663

Closed

Janne Kiiskila and others added 4 commits November 4, 2019 17:57

Update CMSIS pack index json for STM32H7xx family

83daa50

Manually replaced the existing STM32H7 section and replaced it with the context of updated `index.json` that pulled in the Keil packs available today, as of 18th October, 2019. See related PR; ARMmbed#11707

DISCO_H747I - MBED_ROM & device name definition

6028fa7

Compilation of bootloader requires these parameters.

NUCLEO_H743ZI2 - MBED ROM, FlashIAP

fbf6f9b

Add definitions for H743ZI2, required by bootloader.

Review fixes for STM32H7 target.json

eed920e

The proposed review fixes by Jerome, cherry-picked in. (cherry picked from commit fb15f02) Signed-off-by: Janne Kiiskila <[email protected]>

JanneKiiskila force-pushed the CMSIS-STM32H7xx branch from 3f8c9e6 to eed920e Compare November 4, 2019 15:58

jeromecoutant reviewed Nov 5, 2019

View reviewed changes

0xc0170 added the release-version: 5.14.2 label Nov 5, 2019

DISCO_H743ZI/ZI2 - mbed_ram_start/size

1c6a340

Adding the RAM definitions per request of Jerome Coutant.

0xc0170 requested a review from jeromecoutant November 5, 2019 09:43

0xc0170 added needs: review and removed needs: work labels Nov 5, 2019

jeromecoutant approved these changes Nov 5, 2019

View reviewed changes

0xc0170 added needs: CI ready for merge and removed needs: review needs: CI labels Nov 5, 2019

0xc0170 merged commit cdcef4b into ARMmbed:master Nov 5, 2019

0xc0170 removed the ready for merge label Nov 5, 2019

JanneKiiskila deleted the CMSIS-STM32H7xx branch November 6, 2019 11:33

		"mbed_rom_start": "0x08000000",
		"mbed_rom_size" : "0x200000",

Update CMSIS pack index json for STM32H7xx family #11709

Update CMSIS pack index json for STM32H7xx family #11709

Uh oh!

Conversation

JanneKiiskila commented Oct 18, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

jeromecoutant commented Oct 18, 2019

Uh oh!

jeromecoutant Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

jeromecoutant Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

JanneKiiskila commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mark-edgeworth commented Oct 28, 2019

Uh oh!

0xc0170 commented Oct 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Oct 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Oct 31, 2019

Uh oh!

JanneKiiskila commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeromecoutant Nov 5, 2019

Choose a reason for hiding this comment

Uh oh!

JanneKiiskila Nov 5, 2019

Choose a reason for hiding this comment

Uh oh!

JanneKiiskila Nov 5, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 5, 2019

Uh oh!

mbed-ci commented Nov 5, 2019

Test run: FAILED

Uh oh!

JanneKiiskila commented Nov 5, 2019

Uh oh!

0xc0170 commented Nov 5, 2019

Uh oh!

Uh oh!

JanneKiiskila commented Oct 28, 2019 •

edited

Loading

0xc0170 commented Oct 29, 2019 •

edited

Loading

0xc0170 commented Oct 29, 2019 •

edited

Loading

JanneKiiskila commented Nov 1, 2019 •

edited

Loading