Change target name and support InterruptIn function. #1178
Conversation
|
Hello, please always update your branch. The upper case change is already on master : https://github.com/mbedmicro/mbed/blob/master/workspace_tools/targets.py#L74 I'll review and if ok, I'll do manual squash of those 2 into one, to keep just the InterruptIn commit. |
| // uint32_t ids; | ||
| //} irq_channel; | ||
|
|
||
| static uint32_t channel_ids[4][16]; |
There was a problem hiding this comment.
I can see only channel_ids[0][x] used in the code? Is the first index port ? Means the IRQ handlers below need to be updated
|
I added a common handler in gpio_irq_api.c as your guide. |
|
I implemented pwm api. |
|
A note - pwm could be sent as a separate PR (once feature-complete change). I'll review as it is. |
| { | ||
| PWM_CHn_Stop(obj->PWM_CHx); | ||
| // Update the SystemCoreClock variable | ||
| SystemCoreClockUpdate(); |
There was a problem hiding this comment.
Why SystemCoreClockUpdate() is invoked here?
There was a problem hiding this comment.
I want to use correct SystemCoreClock even though user changes the system core clock anytime.
Wiznet - Change target name and support InterruptIn function.
|
I missed to uncomment the function. |
|
I will update next pull request. |
I changed target name WIZwiki_W7500 to WIZWIKI_W7500.
And now WIZWIKI_W7500 support InterruptIn function.