USBMSD: implement MODE SENSE (10) command #11814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandeepmistry, thank you for your changes. |
4 similar comments
|
@sandeepmistry, thank you for your changes. |
|
@sandeepmistry, thank you for your changes. |
|
@sandeepmistry, thank you for your changes. |
|
@sandeepmistry, thank you for your changes. |
|
@sandeepmistry, thank you for your changes. |
facchinm
approved these changes
Nov 8, 2019
0xc0170
approved these changes
Nov 8, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
These changes resolve issue #10342.
The mbed-os USB MSD stack was not responding the "MODE SENSE" command causing macOS not to mount the drive.
cc/ @facchinm
Summary of change (What the change is for and why)
Implemented the MODE SENSE 10 USB MSD command which a response based on what CMSIS DAP sends: https://github.com/ARMmbed/DAPLink/blob/master/source/usb/msc/usbd_msc.c#L665-L699
This change allows macOS to successfully mount the mbed-os USB MSD.
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
This was tested with a Arduino Nano 33 BLE board with macOS 10.14.6.
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
USBMSD: implement MODE SENSE (10) command
Impact of changes
USBMSD
Migration actions required
N/A