Skip to content

Skip Bare Metal green tea test for Network component #11824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2019

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Nov 6, 2019

Description (required)

Net socket, Lora, Cellular,Network test cases require RTOS and will not run in bare metal so added MBED_CONF_RTOS_PRESENT guard to all test cases to skip.

Summary of change (What the change is for and why)

1.Net socket, Lora, Cellular, Network test cases use RTOS functionality(threads, APIs) so this test case cant run in bare-metal

  1. Even if the main test case file main.cpp has MBED_CONF_RTOS_PRESENT guard still green tea test framework build all the depend on c or cpp files related to that test case which creates build issue.
  2. Added the MBED_CONF_RTOS_PRESENT guard to all main test case files and dependency files as well to skip in the build.
  • Note: These changes are done as identified that the network component uses RTOS API and not a very detailed analysis of the component.
  1. Tested the green tea test on below list of targets with bare metal config and added the logs in
    IOTCORE-1397[https://jira.arm.com/browse/IOTCORE-1397] Jira ticket
  • K64F
  • K66F
  • Nucleo F429ZI
  • Nucleo F411RE
  • Nucleo L073RZ
  • Nucleo F207ZG
  1. A main green tea test framework and mbed-os test cases change for bare metal is available in PR Bare metal greentea support #11721
Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@AnttiKauppila @michalpasztamobica @evedon @jamesbeyond


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@rajkan01 rajkan01 changed the title Netsocket,lora,cellular,nework test case requires RTOS so MBED_CONF_R… Skip the network test cases on green tea test for bare-metal Nov 6, 2019
@rajkan01 rajkan01 changed the title Skip the network test cases on green tea test for bare-metal Skip Bare Metal green tea test for Network component Nov 6, 2019
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we cannot use test filtering by name, which is available in the mbed test command, then I don't have any better idea on how to accomplish CI runs for bare metal...

Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea-net branch from 0d62597 to a682fde Compare November 11, 2019 13:01
@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 11, 2019

@adbridge @0xc0170 please start the CI

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 11, 2019

Test run: FAILED

Summary: 1 of 5 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170 0xc0170 merged commit 09c2450 into ARMmbed:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants