Skip to content

Bare metal greentea support #11721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 12, 2019
Merged

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Oct 21, 2019

Description (required)

Enabling green tea test support for bare metal and test cases update

Summary of change (What the change is for and why)
  1. Added the baremetal.json under Tests directory to provide configuration for green tea test framework for bare metal.
  2. Added the required components(mbed-crypto,mbedtls, filesystem etc.,) in baremetal.json to make mbed os build success even though some of those test cases are not supported in bare-metal.
  3. Removed the EMAC and USB_DEVICE from the build even though target have support but those components are not supported in bare metal
  4. Whichever test cases heavily depend on RTOS are guarded with MBED_CONF_RTOS_PRESENT flag so that the green tea framework will mark those test case as "Build Skips" category.
  • Note: Whichever component test cases use the RTOS API but still, those particular components (example: events) can run without RTOS so later we need to work on this issue to make those components test cases to run on bare-metal.
  1. Tested the green tea test on below list of targets with bare metal config and added the logs in IOTCORE-1397[https://jira.arm.com/browse/IOTCORE-1397] Jira ticket
    • K64F
    • K66F
    • Nucleo F429ZI
    • Nucleo F411RE
    • Nucleo L073RZ
    • Nucleo F207ZG
  2. Command to run green tea test for bare metal for NUCLEO_F429ZI,K64F:
    mbed test -m NUCLEO_F429ZI -t GCC_ARM --app-config TESTS/configs/baremetal.json
    mbed test -m K64F -t GCC_ARM --app-config TESTS/configs/baremetal.json
Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@evedon @hugueskamba @jamesbeyond


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@rajkan01 rajkan01 changed the title Bare metal greentea support Work In progress - Bare metal greentea support Oct 21, 2019
@ciarmcom ciarmcom requested review from evedon, hugueskamba, jamesbeyond and a team October 21, 2019 15:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@jamesbeyond @hugueskamba @evedon @ARMmbed/mbed-os-maintainers please review.

@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea branch from 1b5cfbc to e00bad2 Compare October 22, 2019 17:17
@evedon
Copy link
Contributor

evedon commented Oct 23, 2019

Update the PR description and mark that this PR introduces Test update change.

@rajkan01 rajkan01 changed the title Work In progress - Bare metal greentea support Bare metal greentea support Nov 1, 2019
@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea branch 2 times, most recently from c319b85 to 2b8f26c Compare November 5, 2019 14:27
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @rajkan01, 155 changes file would too much for review.
Suggested to breakdown in to smaller PRs, and let individual team-leads to review

 -Added the baremetal.json on Tests directory to enable bare-metal
 -Conditional enable of greentea metrics

Note:
Run green tea with bare metal
mbed test  -m target -t GCC_ARM -n tests-mbed_platform-transaction  --app-config TESTS/baremetal.json
 -Added the mbedtls,crypto,psa,filesystem,fat,littlefs in baremetal.json to resolve compiler issue
 -Disable metrics that are not available for bare metal
 -Moved the baremetal.json inside TESTS/configs directory
@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea branch 2 times, most recently from e2e8b37 to aef2d84 Compare November 5, 2019 19:00
 - RTOS supported test case guarded with MBED_CONF_RTOS_PRESENT flag
 - Added the #error to non supported test case for bare metal
…s to back to original

 -Change the #error description more precisely
 -Separated the MBED_CONF_RTOS_PRESENT guarded
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to enable more bare metal tests. If it does not take too much time we will do it in this PR; if not we will raise tickets to work on it separately.

@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea branch from 688fbe7 to 74d1939 Compare November 7, 2019 18:34
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea branch from 35718a0 to 9e994cf Compare November 8, 2019 14:49
@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea branch 2 times, most recently from f842e19 to bd5fc8d Compare November 9, 2019 00:09
@rajkan01 rajkan01 force-pushed the feature-baremetal-greentea branch from bd5fc8d to 6437f99 Compare November 9, 2019 00:11
@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 11, 2019

@adbridge @0xc0170 Please start the CI

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Nov 12, 2019
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated, we will need to fix some tests that should run with baremetal (everything in platform/hal should do). This comes as result "rtos always included".

@0xc0170 0xc0170 merged commit 09d9287 into ARMmbed:master Nov 12, 2019
ABOSTM added a commit to ABOSTM/mbed-os that referenced this pull request Nov 27, 2019
…d#11721

This test is failed since ARMmbed#11721 Bare metal greentea support
on many STM32 boards:
NUCLEO_F072RB, NUCLEO_F070RB
NUCLEO_F411RE, NUCLEO_F439ZI, NUCLEO_F446ZE, DISCO_F407VG
NUCLEO_F303RE
...
0xc0170 added a commit that referenced this pull request Nov 27, 2019
tests-mbed_hal-sleep_manager: fix regression found on since PR #11721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants