DISCO_H747I: add support of MBED_TICKLESS #11950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ABOSTM, thank you for your changes. |
|
@LMESTM can you please have a look? |
LMESTM
approved these changes
Nov 27, 2019
| } | ||
| LL_HSEM_ReleaseLock(HSEM, CFG_HW_RCC_SEMID, HSEM_CR_COREID_CURRENT); | ||
| #if defined(CORE_CM7) |
There was a problem hiding this comment.
Isn't there a define for CPU1 / CPU2 ?
just in case another DUAL_CORE than H7 may have another split ...
There was a problem hiding this comment.
No, there is no such defined.
I entered an internal change request:
ST_INTERNAL_REF 76709
| LL_HSEM_ReleaseLock(HSEM, CFG_HW_RCC_SEMID, HSEM_CR_COREID_CURRENT); | ||
| #if defined(CORE_CM7) | ||
| LL_PWR_ClearFlag_CPU(); | ||
| #elif defined(CORE_CM4) |
mark-edgeworth
approved these changes
Nov 27, 2019
LMESTM
reviewed
Nov 27, 2019
|
@ABOSTM There's a conflict now, please resolve |
With tickless mechanism hsem can be used for quite a long time (time to set up PLL clock). Also, if hsem is held to long, then this is not the current core which is faulty, but probably the other (the one which hold the HSEM)
port fix ARMmbed#5896 on STM32H7 Cube HAL ST internal ticket 42806 not yet released for STM32H7
ABOSTM
force-pushed
the
DISCO_H747I_TICKLESS
branch
from
fb91d0a to
42a0407
Compare
|
Conflict fixed. |
|
CI started |
Patater
approved these changes
Nov 28, 2019
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
0xc0170
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of change
Pull request type
Test results
Test executed on ST automatic bench:
tests-mbed_drivers-lp_ticker,tests-mbed_drivers-lp_timeout,tests-mbed_drivers-lp_timer,tests-mbed_drivers-rtc,tests-mbed_drivers-sleep_lock,tests-mbed_drivers-ticker,tests-mbed_drivers-timeout,tests-mbed_drivers-timer,tests-mbed_drivers-timerevent,tests-mbed_hal-common_tickers,tests-mbed_hal-common_tickers_freq,tests-mbed_hal-lp_ticker,tests-mbed_hal-rtc,tests-mbed_hal-rtc_reset,tests-mbed_hal-rtc_time,tests-mbed_hal-rtc_time_conv,tests-mbed_hal-sleep,tests-mbed_hal-sleep_manager,tests-mbed_hal-sleep_manager_racecondition,tests-mbed_hal-ticker,tests-mbed_hal-us_ticker,tests-mbed_platform-wait_ns,tests-mbedmicro-rtos-mbed-kernel_tick_count,tests-mbedmicro-rtos-mbed-rtostimer,tests-mbedmicro-rtos-mbed-systimer
All tests are PASSED except for tests-mbed_hal-sleep_manager on some F0, L0 and F4 board: see my comment on #11721
This test, tests-mbed_hal-sleep_manager, is passed with PR #11956