-
Notifications
You must be signed in to change notification settings - Fork 3k
Update Cypress targets #11884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cypress targets #11884
Conversation
@morser499, thank you for your changes. |
Why is this commit needed, should this just be rebased instead and this PR would contain just one commit updating targets? |
Add this to the commit msg at least. A question is why these are not 3 commits but all in one? It's difficult to review ~330 files changed in one commit. |
…pheralNames.h use standard defines
e00f128
to
58805d1
Compare
58805d1
to
33695b3
Compare
Ah I see why you used components, as we have two cores and code needs to be build either for M0 or M4. Can we use target for that? Uhm I'm pretty sure I added a review before but I can't find it now... It went something like:
That being said macros aren't the option if you want to use the build system to exclude directories, but for the core selection you can use target. |
Cleaned up the commit history by breaking items into multiple commits. |
We don't want to promote using the CM0 core. The CM4 is intended for general development. The CM0 should only be used in very special cases. Based on that we are providing the code to allow doing it but it has most functionality disabled. |
@morser499 Why was components chosen? Can we update to use targets? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for component update as asked above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I still don't get why it needs to be done via COMPONENT, if you remove the cores from target.json components fields and rename your directories from COMPONENT_CM0P
to TARGET_M0P
and similar for M4 it should just work.
Our reason for choosing component is that we use this same code in our stand alone reference flow as used here. In that flow we used a number of the same concepts as are done in mbed. However, we have more restrictions on what we consider a TARGET. In our stand alone flow TARGET is used specifically to refer to the board that a user would purchase. This is what defines key parameters for the build process. We use COMPONENT_ to represent any other code that needs to be conditionally included. |
I started CI meanwhile |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
Failures look related
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm Ok fair enough.I'm not so worried about it as this change only touches Cypress code and doesn't introduce global components, but need to highlight it's not what Mbed would consider a component. For once our build system can do something without hacking it which should be noted :)
That being said we are looking into replacing our current build system with cmake soonish, so the concepts of magic directory names will go away.
This should be in CI today (set to 5.15) |
Fix incorrect tag in targets.json. The CY8CPROTO-064-SB board does not have an Arduino header. It was incorrectly put there as part of CI shield testing. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description (required)
Update Cypress targets to be more uniform and reduce what is configured by default to allow more flexibility within mbed.
Summary of change (What the change is for and why)
Regenerated code with latest tools/PDL library
Made PinNames/PeripheralNames reuse existing defines
Remove unneeded peripheral configuration in target design files
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
CY8CKIT_062_WIFI_BT-GCC_ARM.txt
CY8CKIT_062S2_43012-GCC_ARM.txt
CY8CPROTO_063_BLE-GCC_ARM.txt
CYW943012P6EVB_01-GCC_ARM.txt
CY8CKIT_062_BLE-GCC_ARM.txt
NOTE: Failures are due to #11879 and a known incompatibility between the sleep tests and our UART driver.
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required