CellularBase/AT_CellularBase removal #11996

AnttiKauppila · 2019-12-02T12:30:33Z

Removed CellularBase and AT_CellularBase from cellular stack and updated both code and unittests accordingly.

Description

Summary of change

Removed CellularBase and AT_CellularBase from cellular stack and updated both code and unittests accordingly. Also cellular drivers in Mbed OS have been updated.
Earlier cellular device properties were handled in AT_CellularBase class and after this change they are handled now correctly in AT_CellularDevice class. The properties are always modem specific and must be therefore handled in AT_CellularDevice class which is common for all contexts using it.

Also APN lookup and SMS features are now disabled by default
Disabling SMS will save ~4,5kB and APN lookup about ~2kB

Documentation

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

Release Notes

Summary of changes

Removed CellularBase and AT_CellularBase from cellular stack and updated both code and unittests accordingly. Cellular drivers in Mbed OS have been updated.

APN lookup and SMS features are now disabled by default

Impact of changes

Earlier cellular device properties were handled in AT_CellularBase class and after this change they are handled now correctly in AT_CellularDevice class. The properties are always modem specific and must be therefore handled in AT_CellularDevice class which is common for all contexts using it.

CellularBase has been completely removed so those using must now switch to use CellularInterface instead.
Disabling SMS will save ~4,5kB and APN lookup about ~2kB

Migration actions required

Cellular modem drivers must be updated (done for targets in Mbed OS) by removing references to CellularBase.
CellularBase must be changed to CellularInterface if still in use. (was already typedef'ed so no other changes needed)
If SMS or APN lookup are needed by application, those needs to be enabled in mbed_app.json
(cellular.use-apn-lookup: true or cellular.use-sms: true)

ciarmcom · 2019-12-02T14:00:28Z

@AnttiKauppila, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-12-02T15:53:43Z

CI started

mbed-ci · 2019-12-02T16:33:19Z

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-12-03T08:02:51Z

features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.cpp

@AnttiKauppila There's rebase needed

SeppoTakalo · 2019-12-03T09:02:31Z

I'm OK with the removal of the CellularBase class, I did not review functional changes.

0xc0170 · 2019-12-05T07:24:08Z

CI restarted

features/cellular/framework/AT/AT_CellularDevice.h

mbed-ci · 2019-12-05T08:07:09Z

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-12-05T09:12:38Z

CI restarted

mbed-ci · 2019-12-05T09:51:56Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-12-05T13:28:59Z

Regarding release notes:

Cellular modem drivers must be updated (done for targets in Mbed OS)

Is this sufficient? What changes need to be done for drivers - do we have it captured anywhere or do I need to go through the code in this PR to find out?

CellularBase must be changed to CellularInterface if still in use.

CellularBase -> CellularInterface - just replace and works the same ,no changes to the API?

If SMS or APN lookup are needed by application, those needs to be enabled in mbed_app.json

How to enable it, can we add the exact config to enable/disable ?

Removed CellularBase and AT_CellularBase from cellular stack and updated both code and unittests accordingly. Moved property handling into AT_CellularDevice

tools folder had a reference to ppp-cell-iface.apn-lookup which is removed. This commit removes the reference to non-existing configuration

AnttiKauppila · 2019-12-09T13:38:56Z

Release notes updated

0xc0170 · 2019-12-09T16:39:24Z

CI restarted

mbed-ci · 2019-12-09T18:15:18Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

0xc0170 · 2019-12-10T10:45:11Z

@bulislaw Please review, this is then ready for integration

AnttiKauppila added needs: review release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 labels Dec 2, 2019

ciarmcom requested review from a team December 2, 2019 14:00

AriParkkila approved these changes Dec 2, 2019

View reviewed changes

AnttiKauppila added needs: CI and removed needs: review labels Dec 2, 2019

0xc0170 added needs: work and removed needs: CI labels Dec 3, 2019

SeppoTakalo approved these changes Dec 3, 2019

View reviewed changes

kivaisan approved these changes Dec 3, 2019

View reviewed changes

AnttiKauppila force-pushed the feature-cellular branch from 0533254 to 7864929 Compare December 4, 2019 08:55

AnttiKauppila added needs: CI and removed needs: work labels Dec 4, 2019

AnttiKauppila added needs: work and removed needs: CI labels Dec 5, 2019

kivaisan suggested changes Dec 5, 2019

View reviewed changes

features/cellular/framework/AT/AT_CellularDevice.h Show resolved Hide resolved

AnttiKauppila force-pushed the feature-cellular branch from 7864929 to 4e3ff3c Compare December 5, 2019 08:37

kivaisan approved these changes Dec 5, 2019

View reviewed changes

0xc0170 added the BREAKING-CHANGE label Dec 5, 2019

0xc0170 requested a review from bulislaw December 5, 2019 13:25

Antti Kauppila added 7 commits December 9, 2019 15:25

Remove CellularBase and AT_CellularBase

e51230c

Removed CellularBase and AT_CellularBase from cellular stack and updated both code and unittests accordingly. Moved property handling into AT_CellularDevice

CellularStack fixed

90d3dc1

Disable APN lookup by default

30ea858

Disabled SMS by default

7a87023

Fixed unittests

1cb3479

initialisation added for _property_array

e221ba9

APN lookup fix

0f861a1

tools folder had a reference to ppp-cell-iface.apn-lookup which is removed. This commit removes the reference to non-existing configuration

AnttiKauppila force-pushed the feature-cellular branch from 1b7fbb0 to 0f861a1 Compare December 9, 2019 13:32

AnttiKauppila added needs: CI and removed needs: work labels Dec 9, 2019

AnttiKauppila added ready for merge and removed needs: CI labels Dec 10, 2019

0xc0170 added needs: review and removed ready for merge labels Dec 10, 2019

0xc0170 approved these changes Dec 10, 2019

View reviewed changes

bulislaw approved these changes Dec 10, 2019

View reviewed changes

0xc0170 removed the needs: review label Dec 10, 2019

0xc0170 merged commit f10e4ac into master Dec 10, 2019

0xc0170 changed the title ~~Feature cellular~~ CellularBase/AT_CellularBase removal Dec 10, 2019

0xc0170 mentioned this pull request Dec 10, 2019

Config: fix bootloader config errors - propagate errors #12059

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CellularBase/AT_CellularBase removal #11996

CellularBase/AT_CellularBase removal #11996

Uh oh!

AnttiKauppila commented Dec 2, 2019 •

edited by 0xc0170

Loading

Uh oh!

ciarmcom commented Dec 2, 2019

Uh oh!

0xc0170 commented Dec 2, 2019

Uh oh!

mbed-ci commented Dec 2, 2019

Uh oh!

0xc0170 commented Dec 3, 2019

Uh oh!

SeppoTakalo commented Dec 3, 2019

Uh oh!

0xc0170 commented Dec 5, 2019

Uh oh!

Uh oh!

mbed-ci commented Dec 5, 2019

Uh oh!

0xc0170 commented Dec 5, 2019

Uh oh!

mbed-ci commented Dec 5, 2019

Uh oh!

0xc0170 commented Dec 5, 2019

Uh oh!

AnttiKauppila commented Dec 9, 2019

Uh oh!

0xc0170 commented Dec 9, 2019

Uh oh!

mbed-ci commented Dec 9, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

Uh oh!

CellularBase/AT_CellularBase removal #11996

CellularBase/AT_CellularBase removal #11996

Uh oh!

Conversation

AnttiKauppila commented Dec 2, 2019 • edited by 0xc0170 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary of change

Documentation

Pull request type

Test results

Reviewers

@ARMmbed/mbed-os-wan

Release Notes

Summary of changes

Impact of changes

Migration actions required

Uh oh!

ciarmcom commented Dec 2, 2019

Uh oh!

0xc0170 commented Dec 2, 2019

Uh oh!

mbed-ci commented Dec 2, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Dec 3, 2019

Uh oh!

SeppoTakalo commented Dec 3, 2019

Uh oh!

0xc0170 commented Dec 5, 2019

Uh oh!

Uh oh!

mbed-ci commented Dec 5, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Dec 5, 2019

Uh oh!

mbed-ci commented Dec 5, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Dec 5, 2019

Uh oh!

AnttiKauppila commented Dec 9, 2019

Uh oh!

0xc0170 commented Dec 9, 2019

Uh oh!

mbed-ci commented Dec 9, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

Uh oh!

AnttiKauppila commented Dec 2, 2019 •

edited by 0xc0170

Loading