Config: fix bootloader config errors - propagate errors #12059

0xc0170 · 2019-12-09T13:52:53Z

Summary of changes

See #12007, this fixes the config failures. Do not ignore all config failures

Impact of changes

Migration actions required

Documentation

Not needed

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

0xc0170 · 2019-12-09T13:53:16Z

CI started

0xc0170 · 2019-12-09T13:54:40Z

tools/toolchains/mbed_toolchain.py

@@ -894,63 +894,56 @@ def _add_all_regions(self, region_list, active_region_name):
    def add_regions(self):
        """Add regions to the build profile, if there are any.
        """
+
+        if not getattr(self.target, "bootloader_supported", False):
+            return


This is the addition for #12007 . The rest was approved already.

mbed-ci · 2019-12-09T14:30:08Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

madchutney · 2019-12-09T15:13:01Z

tools/toolchains/mbed_toolchain.py

@@ -894,63 +894,56 @@ def _add_all_regions(self, region_list, active_region_name):
    def add_regions(self):
        """Add regions to the build profile, if there are any.
        """
+
+        if not getattr(self.target, "bootloader_supported", False):


I would rather encode the default behaviour in self.target rather than define the default here, other places where this is used may assume a different default. There is also a danger of typos using this technique that would not cause exceptions as if there is a typos the result is always False. Maybe these are relatively minor points but they do somewhat hinder maintainability so should be avoided in code we wish to maintain in the long term.

This is how it is done in regions().
It should be done properly but I don't have entire picture how config works yet . I found this the easiest way to fix now (same check is used inside config but in the later phase when its too late to go back) and later to even rewrite this add_regions to catch errors better.

Do you suggest to have target method to return if bootloader is supported and add_regions() would not even be called if not?

0xc0170 · 2019-12-09T16:35:46Z

There are couple of errors in the targets - they define bootloader support but device_name is missing or target does not contain ROM information. I commited each target separately. Please review, it would be the best to have it enabled back.

Errors were previously silent, therefore this was not seen. You can review the logs in the last CI run above.

cc @ARMmbed/team-renesas @ARMmbed/team-st-mcd @ARMmbed/team-st-mcd

I'll run CI to test this

0xc0170 · 2019-12-09T16:37:42Z

This change was proposed for 5.15rc2. I would like to not having to disable these targets ideally.

jeromecoutant · 2019-12-09T16:55:14Z

device_name is missing

Yes, but we come again to the pack manager issue...
You don't update the json file information with the latest available keil packages...

mbed-ci · 2019-12-09T17:21:02Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-12-09T20:37:24Z

You don't update the json file information with the latest available keil packages...

So that device name is not in targets.json because the json file is outdated? Trying to understand what else we should fix.

0xc0170 · 2019-12-09T20:39:45Z

UNO failed, will fix in the morning

0xc0170 · 2019-12-10T09:02:47Z

CI started

0xc0170 · 2019-12-10T09:43:14Z

Another bug in the tools (if a targes defines sectors, it tries to merge sectors but throwbacks as bootloader is not supported if it set to False).

mbed-ci · 2019-12-10T09:45:41Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-12-10T09:51:01Z

@JanneKiiskila this bugfix disables bootloader for few boards (were not functional before anyway).

0xc0170 · 2019-12-10T10:34:56Z

CI restarted

JanneKiiskila · 2019-12-10T10:57:44Z

You don't update the json file information with the latest available keil packages...

So that device name is not in targets.json because the json file is outdated? Trying to understand what else we should fix.

@jeromecoutant - yes, can you please specify what you mean? CMSIS packs are updated separately to the index.json in the other folder. That, in itself, does not yield updates to the targets.json, someone has to do them manually, I think?

mbed-ci · 2019-12-10T11:08:12Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-12-10T11:32:47Z

Rebased, target should be fixed (I can't compile it locally, having py3 related issues somehow even in the virtualenv).

0xc0170 · 2019-12-10T11:33:02Z

CI started

device_name is missing

An error to be fixed: tools.config.ConfigException: Missing a memory that is read, write in CMSIS Pack data

device_name is missing

device_name missing

device_name is missing

This should be reverted once bootloader is supported.

0xc0170 · 2019-12-10T14:10:22Z

I rebased it to remove one merge commit, clean now

CI started

mbed-ci · 2019-12-10T14:16:29Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

mbed-ci · 2019-12-10T14:46:36Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests

adbridge · 2019-12-10T15:06:31Z

CI restarted

0xc0170 · 2019-12-10T15:21:49Z

@AnttiKauppila Can you review unittest failures here, are they also on master?

[2019-12-10T15:10:58.238Z] CMakeFiles/features-cellular-framework-AT-at_cellularstack.dir/build.make:62: recipe for target 'CMakeFiles/features-cellular-framework-AT-at_cellularstack.dir/features/cellular/framework/AT/at_cellularstack/at_cellularstacktest.cpp.o' failed

This PR was OK until just 2 hours ago (prior merging feature cellular branch). I only added one target fix, rebased to latest master.

We haven't yet run any CI for other PRs.

0xc0170 · 2019-12-10T15:37:32Z

There were 2 PRs to master today (#12051 and #11996) touching unittests cellular.

mbed-ci · 2019-12-10T15:38:59Z

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_unittests
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

AnttiKauppila · 2019-12-10T16:04:41Z

PR to fix unittests here: #12073

0xc0170 · 2019-12-10T16:54:31Z

PR to fix unittests here: #12073

Landed on master, restarting CI

mbed-ci · 2019-12-10T18:16:53Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 9
Build artifacts

0xc0170 · 2019-12-11T11:11:27Z

@ARMmbed/team-cypress @ARMmbed/team-st-mcd @ARMmbed/team-renesas Please review what was disabled in this PR. These targets would be good to have re-enabled with fixing what caused the bootloader failures.

0xc0170 added needs: review release-version: 5.15.0-rc2 labels Dec 9, 2019

0xc0170 requested a review from madchutney December 9, 2019 13:52

0xc0170 commented Dec 9, 2019

View reviewed changes

0xc0170 requested a review from a team December 9, 2019 13:56

madchutney approved these changes Dec 9, 2019

View reviewed changes

0xc0170 requested review from a team December 9, 2019 16:36

0xc0170 force-pushed the JammuKekkonen-remove_hiding_config_errors branch from 372fe58 to 0a79d83 Compare December 10, 2019 08:59

0xc0170 requested a review from JanneKiiskila December 10, 2019 09:50

0xc0170 force-pushed the JammuKekkonen-remove_hiding_config_errors branch from 7d21d38 to c7ec52a Compare December 10, 2019 11:31

0xc0170 removed the needs: review label Dec 10, 2019

0xc0170 added 11 commits December 10, 2019 14:09

NUCLEO_WB55RG: disable bootloader support

b0224ec

device_name is missing

GR_LYCHEE: disable bootloader support

2a16200

An error to be fixed: tools.config.ConfigException: Missing a memory that is read, write in CMSIS Pack data

DISCO_L4R9I: disable bootloader

8d4a166

device_name is missing

CYW9P62S1_43438EVB_01: disable bootloader support

6ec7534

device_name missing

CY8CPROTO_063_BLE: disable bootloader support

054e806

device_name is missing

CY8CPROTO_062_4343W: disable bootloader support

eb5ee71

device_name is missing

CY8CKIT_062_WIFI_BT: disable bootloader support

08b2c58

device_name is missing

CY8CKIT_062_BLE: disable bootloader support

5165275

device_name is missing

UNO_91H: remove sectors, bootloader was disabled

76af152

This should be reverted once bootloader is supported.

STM32F756xG: fix IAR RAM size check

e27f456

TARGET_STM32F74: fix IAR SIZE check in linker scripts

22ab94a

0xc0170 force-pushed the JammuKekkonen-remove_hiding_config_errors branch from b635c59 to 22ab94a Compare December 10, 2019 14:10

adbridge added ready for merge and removed needs: CI labels Dec 10, 2019

adbridge merged commit 0c227a0 into ARMmbed:master Dec 10, 2019

0xc0170 removed the ready for merge label Dec 11, 2019

0xc0170 deleted the JammuKekkonen-remove_hiding_config_errors branch December 11, 2019 11:11

madchutney mentioned this pull request Dec 16, 2019

Notify on configuration exception rather than breaking build #12112

Merged

d-kato mentioned this pull request Jan 9, 2020

RZ_A1H and GR_LYCHEE: Enable bootloader support #12223

Merged

Config: fix bootloader config errors - propagate errors #12059

Config: fix bootloader config errors - propagate errors #12059

Uh oh!

Conversation

0xc0170 commented Dec 9, 2019

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

0xc0170 commented Dec 9, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Dec 9, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Dec 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Dec 9, 2019

Uh oh!

0xc0170 commented Dec 9, 2019

Uh oh!

jeromecoutant commented Dec 9, 2019

Uh oh!

mbed-ci commented Dec 9, 2019

Uh oh!

0xc0170 commented Dec 9, 2019

Uh oh!

0xc0170 commented Dec 9, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

JanneKiiskila commented Dec 10, 2019

Uh oh!

mbed-ci commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

mbed-ci commented Dec 10, 2019

Uh oh!

mbed-ci commented Dec 10, 2019

Uh oh!

adbridge commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Dec 10, 2019

Uh oh!

AnttiKauppila commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 10, 2019

Uh oh!

mbed-ci commented Dec 10, 2019

Uh oh!

0xc0170 commented Dec 11, 2019

Uh oh!

Uh oh!

0xc0170 Dec 9, 2019 •

edited

Loading

0xc0170 commented Dec 10, 2019 •

edited

Loading

0xc0170 commented Dec 10, 2019 •

edited

Loading