Skip to content

Notify on configuration exception rather than breaking build #12112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

madchutney
Copy link
Contributor

@madchutney madchutney commented Dec 16, 2019

Summary of changes

Reimplementation of changes to tools/toolchains/mbed_toolchain.py made in #12059. This change allows older versions of Mbed OS to be build in the online compiler but also adds notifications of configuration errors.

See https://jira.arm.com/browse/IOTBTOOL-515 for further details.

Impact of changes

Keeps backward compatibility but does not raise an error on configuration errors.

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT looks ok to me

@adbridge
Copy link
Contributor

@JammuKekkonen could you please review

@adbridge
Copy link
Contributor

For expediency I'm going to run this through the CI will we await other reviews

@mbed-ci
Copy link

mbed-ci commented Dec 16, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@JammuKekkonen
Copy link
Contributor

Should this go to 5.15 branch only?

@madchutney
Copy link
Contributor Author

Should this go to 5.15 branch only?

If so wouldn't next release break the online compiler backwards compatibility again?

@adbridge
Copy link
Contributor

I think we have to take this for this release and then work out what we do going forward

@adbridge adbridge merged commit 808073b into ARMmbed:master Dec 16, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 16, 2019

👍 for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants