Unittest configuration mechanism improved #12051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier all unittests ended up having all flags in common from all unittest targets.
This is now improved by using googletest provided mechanism to set build time compile options
All cmake files have been modified to reflect changes (when needed)
Could not figure out a syntax for {0x00, 0x00, ..., 0x00} intitializer list yet,
so those needs to be setup by updating C/CXX flags.
SeppoTakalo
approved these changes
Dec 9, 2019
UNITTESTS/features/cellular/framework/AT/athandler/athandlertest.cpp
Outdated
Show resolved
Hide resolved
michalpasztamobica
approved these changes
Dec 9, 2019
0xc0170
added
the
release-version: 6.0.0-alpha-1
0xc0170
approved these changes
Dec 9, 2019
|
CI started |
Test run: SUCCESSSummary: 1 of 1 test jobs passed |
kivaisan
approved these changes
Dec 10, 2019
| -DMDMTXD=NC | ||
| -DMDMRXD=NC | ||
| -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200 | ||
| -DCELLULAR_DEVICE=myCellularDevice |
There was a problem hiding this comment.
Not directly related to this PR, but CELLULAR_DEVICE flag is no longer in use. (Couple of other cmake files has this too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Earlier all unittests ended up having all flags in common from all unittest targets.
This is now improved by using googletest provided mechanism to set build time compile options
All cmake files have been modified to reflect changes (when needed)
Could not figure out a syntax for {0x00, 0x00, ..., 0x00} intitializer list yet,
so those needs to be setup by updating C/CXX flags.
This change touches only UNITTESTS and does not cause any regression for code base.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-ipcore @SeppoTakalo