Skip to content

Unittests: fix for PRs 12051 and 11996 #12073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Unittests: fix for PRs 12051 and 11996 #12073

merged 1 commit into from
Dec 10, 2019

Conversation

AnttiKauppila
Copy link

PRs 12051 and 11996 were merged simultaneously without running tests in between.
This caused unittests to brake and those are fixed with this commit.

Summary of changes

PRs 12051 and 11996 were merged simultaneously without running tests in between.
This caused unittests to brake and those are fixed with this commit.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170

Unittests fixed
bda2d37 
PRs 12051 and 11996 were merged simultaneously without running tests in between.
This caused unittests to brake and those are fixed with this commit.
@AnttiKauppila AnttiKauppila mentioned this pull request Dec 10, 2019
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2019

CI started

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 10, 2019
@mbed-ci
Copy link

mbed-ci commented Dec 10, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2019

Waiting for Travis to complete

@0xc0170 0xc0170 removed the needs: CI label Dec 10, 2019
@0xc0170 0xc0170 merged commit 76ae27e into ARMmbed:master Dec 10, 2019
@0xc0170 0xc0170 changed the title Unittests fixed Unittests: fix for PRs 12051 and 11996 Dec 10, 2019
@AnttiKauppila AnttiKauppila deleted the UT_fixed branch December 10, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnttiKauppila @0xc0170 @mbed-ci