Skip to content

Moved CP Max recv len into mbed_lib.json #12110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

AnttiKauppila
Copy link

@AnttiKauppila AnttiKauppila commented Dec 16, 2019

Summary of changes

Moved CP Max recv len into mbed_lib.json so it can be configured by end developer when needed.
According to [3GPP-TS_24.008] the maximum size for Non-IP link MTU is 1358 octets to prevent fragmentation in the backbone network. Therefore reduced the maximum size to follow the standard.

Impact of changes

Migration actions required

Documentation

mbed_lib.json has a specific help for the value


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

@kjbracey
Copy link
Contributor

Can you justify the value reduction? Non-functional change for existing modems/networks?

@AnttiKauppila
Copy link
Author

@kjbracey-arm Updated summary to have reasoning for value reduction

@kjbracey
Copy link
Contributor

@kjbracey-arm Updated summary to have reasoning for value reduction

Ta. Take care to also update Git commit messages, not just the GitHub description, as it's the Git commit message that's permanent.

According to [3GPP-TS_24.008] the maximum size for Non-IP link MTU is 1358 octets to prevent fragmentation in the backbone network.
Therefore reduced the maximum size to follow the standard.
@AnttiKauppila
Copy link
Author

Commit msg updated

@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit e28daf7 into ARMmbed:master Dec 17, 2019
@adbridge adbridge added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed ready for merge labels Dec 17, 2019
@AnttiKauppila AnttiKauppila deleted the cp_recv_len branch December 18, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants