Skip to content

Moved CP Max recv len into mbed_lib.json #12110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Moved CP Max recv len into mbed_lib.json #12110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/cellular/framework/AT/AT_ControlPlane_netif.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class AT_ControlPlane_netif: public ControlPlane_netif {
private:
void (*_cb)(void *);
void *_data;
char _recv_buffer[MAX_CP_DATA_RECV_LEN];
char _recv_buffer[MBED_CONF_CELLULAR_MAX_CP_DATA_RECV_LEN];
size_t _recv_len;
// Called on receiving URC: +CRTDCP
void urc_cp_recv();
Expand Down
4 changes: 4 additions & 0 deletions features/cellular/mbed_lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
"clear-on-connect" : {
"help": "Clear modem to a known default state on connect() before SIM pin is entered, null to disable",
"value": null
},
"max-cp-data-recv-len" : {
"help": "Max length of the buffer storing data received over control plane",
"value": 1358
}
}
}
5 changes: 3 additions & 2 deletions features/netsocket/cellular/ControlPlane_netif.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@
namespace mbed {

/* Length of the buffer storing data received over control plane */
#define MAX_CP_DATA_RECV_LEN 2048
#ifndef MBED_CONF_CELLULAR_MAX_CP_DATA_RECV_LEN
#define MBED_CONF_CELLULAR_MAX_CP_DATA_RECV_LEN 1358
#endif

// TODO: need to make this l3ip compatible

/**
* @addtogroup cellular
Expand Down