Skip to content

Fix LPC11U35_401 baremetal build #12134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Conversation

toyowata
Copy link
Contributor

@toyowata toyowata commented Dec 19, 2019

Summary of changes

The PR fix LPC11U35_401 baremetal build error and runtime error.
This should be now fixed: ARMmbed/mbed-os-example-blinky-baremetal#15

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Greentea test does not work for this target (Mbed 2 only target).
So, I verified this fix as below:

$ git clone https://github.com/ARMmbed/mbed-os-example-blinky-baremetal
$ cd mbed-os-example-blinky-baremetal
$ echo 'https://github.com/toyowata/mbed/#f9242d0b5c8ecc3a20e5a1f9813c2c1d93c61db9' > mbed-os.lib
$ mbed deploy
$ mbed ls
[mbed] Working path "/Users/toywat01/test/nxp/mbed-os-example-blinky-baremetal" (program)
mbed-os-example-blinky-baremetal (#11e65bf06a7a)
`- mbed-os (#f9242d0b5c8e)
$ mbed compile -m lpc11u35_401 -t arm -f
$ mbed compile -m lpc11u35_401 -t gcc_arm -f
  • It was compiled without error
  • No crash at runtime
  • LED1 blinks as expected timing

I also put printf message in the main.cpp for debug and it worked fine.


Reviewers


@mbed-ci
Copy link

mbed-ci commented Dec 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

adbridge commented Dec 19, 2019

@toyowata could you please fill in the test section? This is there so that we know how this is tested or whether new tests are required. Thanks.
I know you wrote 'Greentea test does not work for this target (Mbed 2 only target).' so my question would thus be, how is this changed verified as working ?
I'm going to hold back merging this until we know it has been verified properly...

@toyowata
Copy link
Contributor Author

@adbridge I updated the test section of this PR. Can you please check?

@adbridge adbridge merged commit bb028ba into ARMmbed:master Dec 23, 2019
@toyowata toyowata deleted the lpc11u35_fix branch December 26, 2019 09:46
],
"overrides": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tickless doesn't work without RTOS...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bulislaw

I needed to add tickless-from-us-ticker to avoid runtime assertion here:

MBED_ASSERT("OS timer not available - check MBED_CONF_TARGET_TICKLESS_FROM_US_TICKER" && false);

Any suggestion to avoid this assertion for the non-RTOS target?

@bulislaw
Copy link
Member

bulislaw commented Jan 7, 2020

Lets pull it in the next patch. Low risk of breaking something.

],
"overrides": {
"tickless-from-us-ticker" : true,
"boot-stack-size" : "0x400"
Copy link
Collaborator

@hugueskamba hugueskamba Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toyowata
How did we come up with 0x400?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we come up with 0x400?

It is from linker script file.

Copy link
Collaborator

@hugueskamba hugueskamba Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure when building for LPC11U35_401 with ARMC6
7 participants