NRF51822: Fix baremetal linker error #12154

hugueskamba · 2019-12-20T14:59:37Z

Summary of changes

Ensure the NRF51822's us_ticker.c module content is compiled in only if the target
supports the microsecond ticker (USTICKER).

Impact of changes

It is now possible to build NRF51822 targets with the baremetal profile using the debug and develop build profiles.
i.e It is now possible to build mbed-os-example-blinky-baremetal with $ mbed compile -t <TOOLCHAIN> -m nrf51_microbit

Migration actions required

Documentation

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-

ciarmcom · 2019-12-20T16:00:38Z

@hugueskamba, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

bulislaw · 2019-12-23T10:07:26Z

Looks similar to #12155 probably won't actually run

hugueskamba · 2020-01-03T07:26:08Z

Looks similar to #12155 probably won't actually run

@bulislaw
Please see #12155 (comment)

Ensure the NRF51822 `us_ticker.c` module content is compiled in only if the target supports USTICKER.

hugueskamba · 2020-01-08T15:34:39Z

Looks similar to #12155 probably won't actually run

The solution here was applied with this force-push.

0xc0170 · 2020-01-08T15:40:19Z

CI started

mbed-ci · 2020-01-08T17:42:48Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_cloud-client-pytest
jenkins-ci/mbed-os-ci_greentea-test

hugueskamba · 2020-01-09T07:24:18Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_cloud-client-pytest

jenkins-ci/mbed-os-ci_greentea-test

Do we think the failure is related to the changes? I have not seen anything that suggested that.

0xc0170 · 2020-01-09T09:53:45Z

Test restarted

0xc0170 · 2020-01-09T12:26:04Z

To understand this one: there is no lp ticker for nrf51x, us ticker is implemented via rtc (already low power), therefore use us ticker during sleep as set here is fine. Is that correct?

evedon · 2020-01-14T10:01:03Z

targets/targets.json

+        ],
+        "overrides": {
+            "tickless-from-us-ticker"   : true,
+            "boot-stack-size"           : "0x400"


Why do we also change boot-stack-size in this PR which addresses a baremetal link error?
I am assuming that there is not enough memory on this target to accommodate the default 4K stack size?

#12155 (comment)
#12134 (comment)

I don't know why we also need to change the boot stack size nor which value it should be set to: 0x800 or 0x400:
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/device/TOOLCHAIN_GCC_ARM/TARGET_MCU_NORDIC_32K/NRF51822.ld/#L4

https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_NORDIC/TARGET_MCU_NRF51822/device/TOOLCHAIN_IAR/TARGET_MCU_NORDIC_32K/nRF51822_QFAA.icf/#L7

@mprse You worked on this some time ago, can you give your view?

0xc0170 · 2020-01-15T15:22:48Z

CI started

mbed-ci · 2020-01-15T16:10:47Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

0xc0170 · 2020-01-16T13:44:50Z

This shall be ready for integration once approved, cc @evedon

adbridge · 2020-01-20T15:26:13Z

NOTE: We shall probably have to re-run CI on this before merging due to the number of days since it last ran...

bulislaw · 2020-01-21T16:45:20Z

Did anyone checked whether it actually works after compiling? If yes, it's fine with me.

adbridge · 2020-01-22T14:09:21Z

Did anyone checked whether it actually works after compiling? If yes, it's fine with me.

@hugueskamba @evedon ^^^^

evedon · 2020-01-22T15:03:15Z

Did anyone checked whether it actually works after compiling? If yes, it's fine with me.

@hugueskamba @evedon ^^^^

Successfully built mbed-os-example-blinky-baremetal for NRF51822 with this PR.

adbridge · 2020-01-23T14:54:55Z

@evedon could you approve then please and I will rerun this through the CI and then we should be able to get this in.

adbridge · 2020-01-23T14:56:43Z

CI started

mbed-ci · 2020-01-23T16:02:18Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

adbridge · 2020-01-23T17:00:04Z

Re running CI as I cannot see why this failed

mbed-ci · 2020-01-23T17:54:52Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

hugueskamba force-pushed the hk-baremetal-nrf51822-fix branch from 926950d to d8dc2a2 Compare December 20, 2019 15:07

ciarmcom requested review from pan- and a team December 20, 2019 16:00

ciarmcom added the needs: review label Dec 20, 2019

NRF51822: Fix baremetal linker error

e0c628c

Ensure the NRF51822 `us_ticker.c` module content is compiled in only if the target supports USTICKER.

hugueskamba force-pushed the hk-baremetal-nrf51822-fix branch from d8dc2a2 to e0c628c Compare January 8, 2020 15:33

0xc0170 approved these changes Jan 8, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jan 9, 2020

0xc0170 self-requested a review January 9, 2020 12:23

0xc0170 added needs: review and removed needs: CI labels Jan 9, 2020

evedon reviewed Jan 14, 2020

View reviewed changes

0xc0170 approved these changes Jan 15, 2020

View reviewed changes

0xc0170 requested a review from evedon January 16, 2020 13:44

0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Jan 16, 2020

adbridge added needs: CI and removed needs: review labels Jan 23, 2020

mergify bot added ready for merge and removed needs: CI labels Jan 23, 2020

adbridge added needs: CI and removed ready for merge labels Jan 23, 2020

mergify bot added ready for merge and removed needs: CI labels Jan 23, 2020

adbridge added needs: CI and removed ready for merge labels Jan 23, 2020

mergify bot added ready for merge and removed needs: CI labels Jan 23, 2020

adbridge merged commit 0d48a26 into ARMmbed:master Jan 24, 2020

adbridge removed the ready for merge label Jan 24, 2020

hugueskamba deleted the hk-baremetal-nrf51822-fix branch June 30, 2020 11:38

NRF51822: Fix baremetal linker error #12154

NRF51822: Fix baremetal linker error #12154

Uh oh!

Conversation

hugueskamba commented Dec 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Dec 20, 2019

Uh oh!

bulislaw commented Dec 23, 2019

Uh oh!

hugueskamba commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugueskamba commented Jan 8, 2020

Uh oh!

0xc0170 commented Jan 8, 2020

Uh oh!

mbed-ci commented Jan 8, 2020

Uh oh!

hugueskamba commented Jan 9, 2020

Uh oh!

0xc0170 commented Jan 9, 2020

Uh oh!

0xc0170 commented Jan 9, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 15, 2020

Uh oh!

mbed-ci commented Jan 15, 2020

Uh oh!

0xc0170 commented Jan 16, 2020

Uh oh!

adbridge commented Jan 20, 2020

Uh oh!

bulislaw commented Jan 21, 2020

Uh oh!

adbridge commented Jan 22, 2020

Uh oh!

evedon commented Jan 22, 2020

Uh oh!

adbridge commented Jan 23, 2020

Uh oh!

adbridge commented Jan 23, 2020

Uh oh!

mbed-ci commented Jan 23, 2020

Uh oh!

adbridge commented Jan 23, 2020

Uh oh!

mbed-ci commented Jan 23, 2020

Uh oh!

Uh oh!

hugueskamba commented Dec 20, 2019 •

edited

Loading

hugueskamba commented Jan 3, 2020 •

edited

Loading