Skip to content

MIMXRT1050: Add Watchdog support #12299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

MIMXRT1050: Add Watchdog support #12299

merged 1 commit into from
Jan 31, 2020

Conversation

mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented Jan 22, 2020 •
edited
Loading

Summary of changes

Add WatchDog support for MXRT1050 EVK

Impact of changes

NONE

Migration actions required

NONE

Documentation

NONE

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

mbedgt: test case report:

target platform_name test suite test case
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog Init, 100 ms
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog Init, max_timeout
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog Platform feature max_timeout is
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog Stopped watchdog can be started
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog Update config with multiple init
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog Watchdog can be stopped
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_reset Kicking the Watchdog prevents re
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_reset Watchdog reset
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_reset Watchdog reset in deepsleep mode
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_reset Watchdog reset in sleep mode
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_reset Watchdog started again
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_timing Timing, 1000 ms
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_timing Timing, 200 ms
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_timing Timing, 3000 ms
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_timing Timing, 500 ms
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-watchdog_timing timeout accuracy
mbedgt: test case results: 16 OK

Reviewers

@ciarmcom ciarmcom requested review from maclobdell and a team January 22, 2020 04:00
@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

@mmahadevan108 Looks like you have removed sections from the PR template. Could you please put them back and fill them in as per the guidelines. Thank you.

@mmahadevan108
Copy link
Contributor Author

Sorry for this, I have fixed it

@adbridge
Copy link
Contributor

Sorry for this, I have fixed it

Is there any impact of the changes ? Are there any migration actions required by users ? If neither please just add 'None' to the sections :)

adbridge
adbridge previously requested changes Jan 24, 2020
View reviewed changes
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_IMX/watchdog_api.c Outdated
* periods of wdog32 clock to reconfigure wodg32. So Delay a while to wait for
* the previous configuration taking effect. */
for (temp = 0; temp < DELAY_TIME; temp++)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open bracket should be on the preceding line as per our coding guidelines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have fixed this.

@mmahadevan108
MIMXRT1050: Add Watchdog support
72bd899 
Signed-off-by: Mahesh Mahadevan <[email protected]>
@mergify mergify bot dismissed adbridge’s stale review January 24, 2020 13:26

Pull request has been modified.

@mmahadevan108
Copy link
Contributor Author

Sorry for this, I have fixed it

Is there any impact of the changes ? Are there any migration actions required by users ? If neither please just add 'None' to the sections :)

Updated these sections

maclobdell
maclobdell reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@maclobdell maclobdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. thanks.

@maclobdell
Copy link
Contributor

@adbridge - is there anything else needed on this? Can it be tested and merged?

maclobdell
maclobdell approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@maclobdell maclobdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@mergify mergify bot added needs: CI and removed needs: work labels Jan 30, 2020
@jamesbeyond
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@kjbracey kjbracey merged commit 236c336 into ARMmbed:master Jan 31, 2020
@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

I've fixed the version: Set to 6.0.0-alpha-2

@adbridge
Copy link
Contributor

Requested by Tuomo for consideration for LTS branch.

@artokin artokin mentioned this pull request Mar 3, 2020
Merged
@adbridge
Copy link
Contributor

adbridge commented Apr 8, 2020

This went to a feature branch so assuming this will not go across to 5.15 proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclobdell maclobdell maclobdell approved these changes

@adbridge adbridge adbridge left review comments

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mmahadevan108 @ciarmcom @adbridge @maclobdell @jamesbeyond @mbed-ci @0xc0170 @kjbracey