Skip to content

MIMXRT1050: Update for deep sleep latency #12364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

MIMXRT1050: Update for deep sleep latency #12364

merged 1 commit into from
Feb 7, 2020

Conversation

mmahadevan108
Copy link
Contributor

Summary of changes

  1. Do not disable and enable osillators during deep sleep
    entry and exit
  2. Increase the deep sleep to pass tests

Impact of changes

NONE

Migration actions required

NONE

Documentation

NONE

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@maclobdell

@ciarmcom ciarmcom requested review from maclobdell and a team February 4, 2020 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 4, 2020

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these lines are not removed (it is now dead code) ? I would rather remove it. It's stored in the history so can be found and reverted or changed.

bulislaw
bulislaw reviewed Feb 5, 2020
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you introducing a dead code? If for some use cases we expect users to want to "revert" this maybe worth introducing a named macro?

@mmahadevan108
MIMXRT1050: Update for deep sleep latency
8b46e91 
1. Do not disable and enable osillators during deep sleep
   entry and exit
2. Increase the deep sleep to pass tests

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108 mmahadevan108 force-pushed the MXRT1050_Deep_Sleep_Latency branch from 5f2399a to 8b46e91 Compare February 5, 2020 16:39
@mergify mergify bot dismissed 0xc0170’s stale review February 5, 2020 16:40

Pull request has been modified.

@mmahadevan108
Copy link
Contributor Author

Deleted the unused lines.

@mbed-ci
Copy link

mbed-ci commented Feb 6, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 7, 2020
@0xc0170 0xc0170 merged commit 2719090 into ARMmbed:master Feb 7, 2020
@mergify mergify bot removed the ready for merge label Feb 7, 2020
@mmahadevan108 mmahadevan108 deleted the MXRT1050_Deep_Sleep_Latency branch February 11, 2020 15:54
@adbridge
Copy link
Contributor

Requested by Tuomo for consideration for LTS branch.

@artokin artokin mentioned this pull request Mar 3, 2020
Merged
@adbridge
Copy link
Contributor

adbridge commented Apr 8, 2020

This went to a feature branch so assuming this will not go to 5.15 proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmahadevan108 @ciarmcom @mbed-ci @adbridge @bulislaw @0xc0170