-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix issue when TDBStore has varying erase sizes between areas. #12558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In some cases, it is possible that every erase unit in area 0 has the same size, but they are still different than in area 1. Remove the flag for varying erase sizes and instead check from flash, what is the erase size of the current unit.
@jarlamsa, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
CI started |
Test run: FAILEDSummary: 2 of 7 test jobs failed Failed test jobs:
|
@0xc0170 The errors seem to be CI-related, please restart. |
CI restarted |
@jarlamsa in order to bring this cleanly to the mbed-os-5.15 branch could we please have an equivalent PR directly to that branch. We are getting PRs directly to that branch with functionality that is either not supported on Master or has deviated and thus we have a diverging code base. By creating an equivalent PR to this directly against that branch will enable us to ensure that the PR lands in time and cleanly. Thanks. We will then move the release version label over to that PR. |
@adbridge sure, I'll provide that soon. |
Summary of changes
In some cases, it is possible that every erase unit in area 0
has the same size, but they are still different than in area 1.
Remove the flag for varying erase sizes and instead check every time
from flash, what is the erase size of the current unit.
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-storage
@soleilplanet