Fix issue when TDBStore has varying erase sizes between areas. (Backport) #12653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, it is possible that every erase unit in area 0 has the same size, but they are still different than in area 1. Remove the flag for varying erase sizes and instead check from flash, what is the erase size of the current unit.
|
This has already been approved for 5.15.2. |
SeppoTakalo
approved these changes
Mar 19, 2020
|
CI started Note: dynamic test will most likely fail, will be fixed today |
Test run: FAILEDSummary: 2 of 7 test jobs failed Failed test jobs:
|
|
@0xc0170 could you retrigger the CI if the dynamic memory tests are now stable? |
|
CI restarted |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
|
I restarted tests, there were usb failures |
|
mmm still seeing the USB failures... |
|
This needs a fix to how the USB tests are run (@jamesbeyond will raise shortly) |
|
test restarted |
|
Started new CI job |
0xc0170
approved these changes
Apr 1, 2020
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is a backport of #12558 to
mbed-os-5.15In some cases, it is possible that every erase unit in area 0
has the same size, but they are still different than in area 1.
Remove the flag for varying erase sizes and instead check from
flash, what is the erase size of the current unit.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-storage
@soleilplanet
@adbridge