M263: Support custom board #12642
Merged
M263: Support custom board #12642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccli8, thank you for your changes. |
0xc0170
previously approved these changes
Mar 19, 2020
|
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
|
Looks like new MCU target is getting build (not set to private?) |
0xc0170
reviewed
Mar 19, 2020
| @@ -14712,13 +14712,12 @@ | |||
| "5" | |||
| ] | |||
| }, | |||
| "NUMAKER_IOT_M263A": { | |||
| "MCU_M261": { | |||
There was a problem hiding this comment.
As noted in my comment, if this is base MCU, needs to be private
There was a problem hiding this comment.
@0xc0170 Fixed it. Thanks for your explanation.
This is to support M261 series based targets.
Don't set SERIAL_TX/SERIAL_RX to USBTX/USBRX which should be dedicated for USB VCOM and not for other uses.
This is to support custom boards based on M261 series chips.
- STDIO_UART and STDIO_UART_TX/STDIO_UART_RX - USB_UART and USBTX/USBRX
This is to support custom boards based on M261 series chips.
ccli8
force-pushed
the
nuvoton_m263_custom_board
branch
from
6901277 to
f5cb899
Compare
0xc0170
approved these changes
Mar 23, 2020
|
CI restarted |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Continuing #12576, this PR tries to support custom board based on M261 series chips by enabling capability of being configurable for the following items:
Pull request type
Test results