Skip to content

M487: Support custom board #12576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 17, 2020
Merged

M487: Support custom board #12576

merged 9 commits into from
Mar 17, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Mar 5, 2020

Summary of changes

This PR tries to support custom board based on M480 series chips by enabling capability of being configurable for the following items:

  1. Pin definitions
  2. UART for USB VCOM and STDIO
  3. SPIM CCM mode
  4. Flash/SRAM specification (start/size)

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ciarmcom ciarmcom requested review from Ronny-Liu and a team March 5, 2020 08:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 5, 2020

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Mar 9, 2020
View reviewed changes
targets/targets.json Outdated
"help": "Configure STDIO_UART_RX. STDIO_UART and STDIO_UART_TX/STDIO_UART_RX must be consistent. STDIO_UART_RX defaults to USBRX.",
"value": null
},
"custom-pinname-file": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the use case for this, why do we need this "header file name" here? I dont recall seeing this before in other targets, the overwrite is done differently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed custom-pinname-file. Re-organize PinNames.h so that custom PinNames.h can place in custom target (TARGET_) folder.

@ccli8 ccli8 force-pushed the nuvoton_m487_custom_board branch from b8c64f3 to bee9625 Compare March 10, 2020 03:24
adbridge
adbridge previously approved these changes Mar 10, 2020
View reviewed changes
@adbridge
Copy link
Contributor

@Ronny-Liu would you like to also review ?

@mergify mergify bot added needs: CI and removed needs: review labels Mar 10, 2020
Ronny-Liu
Ronny-Liu approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@Ronny-Liu Ronny-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ccli8 added 9 commits March 12, 2020 09:31
@ccli8
M487: Change SERIAL_TX/SERIAL_RX pin names to other than USBTX/USBRX
c4ffd38 
USBTX/USBRX should be dedicated for USB VCOM and not for other uses.
@ccli8
M487: Remove BUTTON1/2 for custom targets
2f770b7 
This is to support custom targets based on M480 series chips.
@ccli8
M487: Make SPIM CCM mode configurable
98c151a 
This is to support custom targets based on M480 series chips.
@ccli8
M487: Disable MBEDTLS_CONFIG_HW_SUPPORT for custom targets
43f297f 
This is to support custom targets based on M480 series chips.
@ccli8
M487: Disable network default interface type for custom targets
6f30d4f 
This is to support custom targets based on M480 series chips.

For Mbed-Enabled boards:

-   NUMAKER_PFM_M487: ETHERNET
-   NUMAKER_IOT_M487: WIFI
@ccli8
M487: Enable FLASHIAP for custom targets
58e0048 
This is to support custom targets based on M480 series chips.
@ccli8
M487: Make memory specification configurable
9d26390 
This is to support custom targets based on M480 series chips.
@ccli8
M487: Support configurability of USB/STDIO UART pins
2cf8282 
-   STDIO_UART and STDIO_UART_TX/STDIO_UART_RX
-   USB_UART and USBTX/USBRX
@ccli8
M487: Re-organize PinNames.h
5ec8641 
This is to support custom targets based on M480 series chips.
@ccli8 ccli8 force-pushed the nuvoton_m487_custom_board branch from bee9625 to 5ec8641 Compare March 12, 2020 02:30
@mergify mergify bot dismissed adbridge’s stale review March 12, 2020 02:31

Pull request has been modified.

@ccli8
Copy link
Contributor Author

ccli8 commented Mar 12, 2020

Make modifications:

  1. Do rebase
  2. Fix flash_start of flash_target_config struct to support configurable of memory spec (flash_api.c).

@adbridge
Copy link
Contributor

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 12, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 12, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@ccli8
Copy link
Contributor Author

ccli8 commented Mar 17, 2020

What's the error?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 17, 2020

Client test restarted

@0xc0170 0xc0170 merged commit 6964679 into ARMmbed:master Mar 17, 2020
@mergify mergify bot removed the ready for merge label Mar 17, 2020
This was referenced Mar 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@bulislaw bulislaw bulislaw approved these changes

@adbridge adbridge adbridge approved these changes

@Ronny-Liu Ronny-Liu Ronny-Liu approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ccli8 @ciarmcom @adbridge @mbed-ci @0xc0170 @bulislaw @Ronny-Liu