Skip to content

M2351: Support custom board #12660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2020
Merged

M2351: Support custom board #12660

merged 3 commits into from
Mar 31, 2020

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Mar 20, 2020

Summary of changes

Continuing #12576, this PR tries to support custom board based on M2351 series chips by enabling capability of being configurable for the following items:

  1. Introduce MCU_M2351 target to be inheritable
  2. Re-organize PinNames.h to be overridable
  3. Enable configurability of USB/STDIO UART pins

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
M2351: Support custom board
427e8eb 
1. Introduce MCU_M2351 target to be inheritable
2. Re-organize PinNames.h to be overridable
3. Enable configurability of USB/STDIO UART pins
@ciarmcom ciarmcom requested review from Ronny-Liu and a team March 20, 2020 10:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall seeing these changes before, was it closed and this is a new one? Looks fine to me just SDPX : see @mbed-bot travis-ci/licence_check — Needs review, 2 license issues found

targets/TARGET_NUVOTON/TARGET_M2351/TARGET_NU_PFM_M2351/PinNames.h
@@ -0,0 +1,116 @@
/* mbed Microcontroller Library
* Copyright (c) 2017-2018 Nuvoton
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add SPDX identifier to new files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added SPDX identifier to all M2351 files.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

I recall seeing these changes before, was it closed and this is a new one?

Another MCU family, just checked

@mergify mergify bot dismissed 0xc0170’s stale review March 24, 2020 03:16

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

Will restart tests later today

@0xc0170 0xc0170 merged commit 0a6e586 into ARMmbed:master Mar 31, 2020
@mergify mergify bot removed the ready for merge label Mar 31, 2020
@ccli8 ccli8 deleted the nuvoton_m2351_custom_board branch March 31, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@Ronny-Liu Ronny-Liu Awaiting requested review from Ronny-Liu

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci