Migrate NUCLEO_F303K8 to Mbed OS 5 baremetal #12663

hugueskamba · 2020-03-20T12:17:27Z

Summary of changes

Use two memory regions in ARM toolchain linker file to support Microlib
Replace target.default_lib with target.c_lib
Specify supported lib sizes per toolchain
Add support for Mbed OS 5

This was tested with all supported toolchains (GCC_ARM, ARM, and IAR).
This PR is needed to build with the IAR toolchain.

The test included building and running mbed-os-example-blinky-baremetal as well as running the bare metal Greentea test suite (mbed test -t arm -m NUCLEO_F303K8 --app-config TESTS/configs/baremetal.json). All tests were successful.

Impact of changes

The NUCLEO_F303K8 target can now be built with Mbed OS 5 bare metal profile.

Migration actions required

N/A

Documentation

N/A

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @jeromecoutant @rajkan01

jeromecoutant

I can't currently test as I didn't plan to work on that target now that we are working at home...

targets/TARGET_STM/TARGET_STM32F3/TARGET_STM32F303x8/device/TOOLCHAIN_ARM_STD/stm32f303x8.sct

targets/targets.json

ciarmcom · 2020-03-20T14:00:42Z

@hugueskamba, thank you for your changes.
@rajkan01 @evedon @jeromecoutant @ARMmbed/mbed-os-maintainers please review.

evedon · 2020-03-20T16:48:58Z

Great to see one more target ported to bare metal!
Could you update the "Impact of changes" section and put N/A for the other sections.
Also please add a comment to say on which toolchains you tested.

evedon

Code change looks good.

jeromecoutant · 2020-03-23T08:09:32Z

@hugueskamba
Could you provide test results ?

@0xc0170
As this PR affects all STM32, can you start CI to check ?

hugueskamba · 2020-03-23T10:12:17Z

@hugueskamba
Could you provide test results ?

Done.

0xc0170 · 2020-03-23T10:14:45Z

CI started meanwhile

0xc0170 · 2020-03-23T13:19:45Z

Looking at the test failures, #12665 is needed here , I'll set the preceding PR needed

hugueskamba · 2020-03-25T12:52:59Z

Looking at the test failures, #12665 is needed here , I'll set the preceding PR needed

This one instead #12691

targets/targets.json

hugueskamba · 2020-04-15T08:29:34Z

Looking at the test failures, #12665 is needed here , I'll set the preceding PR needed

This one instead #12691

The required changes to fix IAR support have now been merged to master.
@0xc0170 can you please run the CI tests or do I have to rebase my branch?

Pull request has been modified.

hugueskamba · 2020-04-20T18:51:28Z

This force-push updates the targets.json file as per the Mbed 2 target porting guidelines.

0xc0170 · 2020-04-20T19:54:47Z

CI started

mbed-ci · 2020-04-21T00:39:50Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2020-04-21T09:23:21Z

test restarted

evedon · 2020-04-21T09:30:15Z

targets/targets.json

-        "release_versions": [
-            "2"
-        ],
+        "supported_application_modes":["bare-metal"],


Migration guide was updated to use supported_application_profiles.

* Use two memory regions in ARM toolchain linker file to support Microlib * Replace `target.default_lib` with `target.c_lib` * Specify supported lib sizes per toolchain * Add support for Mbed OS versions after Mbed 2

0xc0170 · 2020-04-21T14:00:54Z

CI restarted

mbed-ci · 2020-04-21T14:57:48Z

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 3
Build artifacts

jeromecoutant · 2020-04-29T14:59:15Z

targets/targets.json

@@ -3630,12 +3635,14 @@
            }
        },
        "overrides": {
-            "lse_available": 0
+            "lse_available": 0,
+            "boot-stack-size": "0x400",


Why?
As explained in
https://os.mbed.com/docs/mbed-os/v5.15/porting/porting-bootstrap.html
/* This value is normally defined by the tools to 0x1000 for bare metal and 0x400 for RTOS */

So why don't we keep default 0x1000 value ?
Thx

jeromecoutant suggested changes Mar 20, 2020

View reviewed changes

targets/TARGET_STM/TARGET_STM32F3/TARGET_STM32F303x8/device/TOOLCHAIN_ARM_STD/stm32f303x8.sct Outdated Show resolved Hide resolved

targets/targets.json Show resolved Hide resolved

targets/targets.json Outdated Show resolved Hide resolved

targets/targets.json Show resolved Hide resolved

hugueskamba force-pushed the hk-NUCLEO_F303K8-fix-microlib-support-optimize-ram branch from edafefb to 0753eba Compare March 20, 2020 13:16

ciarmcom requested review from evedon, jeromecoutant, rajkan01 and a team March 20, 2020 14:00

ciarmcom added the needs: review label Mar 20, 2020

evedon reviewed Mar 20, 2020

View reviewed changes

evedon previously approved these changes Mar 23, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Mar 23, 2020

0xc0170 added needs: preceding PR and removed needs: CI labels Mar 23, 2020

jeromecoutant reviewed Mar 26, 2020

View reviewed changes

targets/targets.json Show resolved Hide resolved

hugueskamba force-pushed the hk-NUCLEO_F303K8-fix-microlib-support-optimize-ram branch from 0753eba to e443aa7 Compare April 20, 2020 18:49

0xc0170 added needs: CI and removed needs: preceding PR labels Apr 20, 2020

evedon reviewed Apr 21, 2020

View reviewed changes

Migrate NUCLEO_F303K8 to Mbed OS 5 baremetal

4e61240

* Use two memory regions in ARM toolchain linker file to support Microlib * Replace `target.default_lib` with `target.c_lib` * Specify supported lib sizes per toolchain * Add support for Mbed OS versions after Mbed 2

hugueskamba force-pushed the hk-NUCLEO_F303K8-fix-microlib-support-optimize-ram branch from e443aa7 to 4e61240 Compare April 21, 2020 11:11

0xc0170 requested a review from jeromecoutant April 21, 2020 15:27

0xc0170 added needs: review release-version: 6.0.0-beta-1 and removed needs: CI labels Apr 21, 2020

0xc0170 approved these changes Apr 21, 2020

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Apr 22, 2020

0xc0170 merged commit e33e936 into ARMmbed:master Apr 22, 2020

mergify bot removed the ready for merge label Apr 22, 2020

0xc0170 approved these changes Apr 22, 2020

View reviewed changes

hugueskamba deleted the hk-NUCLEO_F303K8-fix-microlib-support-optimize-ram branch April 22, 2020 09:07

jeromecoutant reviewed Apr 29, 2020

View reviewed changes

jeromecoutant mentioned this pull request May 18, 2020

OS timer uses LPTICKER by default, then USTICKER #12988

Merged

Migrate NUCLEO_F303K8 to Mbed OS 5 baremetal #12663

Migrate NUCLEO_F303K8 to Mbed OS 5 baremetal #12663

Uh oh!

Conversation

hugueskamba commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ciarmcom commented Mar 20, 2020

Uh oh!

evedon commented Mar 20, 2020

Uh oh!

evedon left a comment

Choose a reason for hiding this comment

Uh oh!

jeromecoutant commented Mar 23, 2020

Uh oh!

hugueskamba commented Mar 23, 2020

Uh oh!

0xc0170 commented Mar 23, 2020

Uh oh!

0xc0170 commented Mar 23, 2020

Uh oh!

hugueskamba commented Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hugueskamba commented Apr 15, 2020

Uh oh!

hugueskamba commented Apr 20, 2020

Uh oh!

0xc0170 commented Apr 20, 2020

Uh oh!

mbed-ci commented Apr 21, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Apr 21, 2020

Uh oh!

evedon Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

hugueskamba Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Apr 21, 2020

Uh oh!

mbed-ci commented Apr 21, 2020

Test run: SUCCESS

Uh oh!

jeromecoutant Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hugueskamba commented Mar 20, 2020 •

edited

Loading

hugueskamba commented Mar 25, 2020 •

edited

Loading