Replace small with std C lib if not supported by a target's toolchain #12691

hugueskamba · 2020-03-24T18:13:32Z

Summary of changes

Display a post-build warning indicating to the user that the standard C
library was used instead of the small C library if the former is not
supported.

fixes #12585

Impact of changes

Targets that have specified to build with the small C lib can still be built with the standard C lib if the small C lib is not supported for a given toolchain. For example, as Mbed 2 targets typically specify the small C lib, they can still be built with the IAR toolchain (which does not have a small C lib) if the standard C lib is supported.

Migration actions required

N/A

Documentation

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@evedon @rajkan01 @mark-edgeworth @madchutney

ciarmcom · 2020-03-24T20:00:35Z

@hugueskamba, thank you for your changes.
@mark-edgeworth @madchutney @rajkan01 @evedon @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

tools/toolchains/mbed_toolchain.py

tools/toolchains/arm.py

mark-edgeworth · 2020-03-25T09:43:12Z

tools/toolchains/gcc.py

+            toolchain = "gcc_arm"
+
+            if is_std_c_lib_supported_instead_small_c_lib(target, toolchain):
+                # Replace small C lib with std if there is no small C lib support
+                target.c_lib = "std"
+
+            self.check_c_lib_supported(target, toolchain)


tools/build_api.py

Pull request has been modified.

tools/toolchains/mbed_toolchain.py

Pull request has been modified.

mark-edgeworth

Sorry for being picky on this, but I'm keen that we make the code that we add better than that which already exists. This codebase is pretty bad generally: anything we can do to improve matters helps a great deal!

tools/toolchains/mbed_toolchain.py

Pull request has been modified.

mark-edgeworth · 2020-03-25T14:32:15Z

tools/toolchains/mbed_toolchain.py

+    """
+    Check if a library type is supported by a toolchain for a given target.
+
+    Return True if the library type is supported, False if not supported, and


missing something here....

tools/toolchains/mbed_toolchain.py

Pull request has been modified.

hugueskamba · 2020-03-25T14:51:40Z

This force-push squashes all commits.

evedon

Looks great!

evedon · 2020-03-31T10:07:22Z

The travis events issue was fixed in https://github.com/ARMmbed/mbed-os/pull/12629/files

Display a post-build warning indicating to the user that the standard C library was used instead of the small C library if the former is not supported.

Pull request has been modified.

hugueskamba · 2020-03-31T10:38:47Z

This force-push rebased from master to ensure the travis events issue is fixed.

evedon · 2020-04-01T11:07:38Z

Travis events issue is fixed. Let's start CI next.

evedon

Re-reviewed.

adbridge · 2020-04-02T09:43:08Z

CI started, I'm assuming CI on master is working again ....

mbed-ci · 2020-04-02T18:05:11Z

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2020-04-03T08:28:28Z

Known issue, will be restarted

evedon · 2020-04-06T09:04:08Z

Known issue, will be restarted

Has the CI issue been fixed?

0xc0170 · 2020-04-06T09:06:16Z

No, still fails for most of PRs, multiple issues being looked at by @ARMmbed/mbed-os-test team

0xc0170 · 2020-04-09T13:56:13Z

Started CI

mbed-ci · 2020-04-09T14:22:33Z

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2020-04-09T19:05:27Z

restarted CI

mbed-ci · 2020-04-09T19:50:54Z

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2020-04-14T14:34:10Z

CI restarted

mbed-ci · 2020-04-14T16:01:48Z

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 5
Build artifacts

hugueskamba mentioned this pull request Mar 24, 2020

Enable build with IAR when c_lib is set to small #12665

Closed

ciarmcom requested review from evedon, madchutney, mark-edgeworth, rajkan01 and a team March 24, 2020 20:00

ciarmcom added the needs: review label Mar 24, 2020

mark-edgeworth previously requested changes Mar 25, 2020

View reviewed changes

mergify bot added needs: work and removed needs: review labels Mar 25, 2020

hugueskamba force-pushed the hk_replace_small_lib_with_std_lib branch from d072cb8 to 0e9c83e Compare March 25, 2020 12:43

hugueskamba mentioned this pull request Mar 25, 2020

Migrate NUCLEO_F303K8 to Mbed OS 5 baremetal #12663

Merged

mark-edgeworth previously requested changes Mar 25, 2020

View reviewed changes

tools/toolchains/mbed_toolchain.py Outdated Show resolved Hide resolved

hugueskamba force-pushed the hk_replace_small_lib_with_std_lib branch from 0e9c83e to 12704f8 Compare March 25, 2020 14:05

mark-edgeworth suggested changes Mar 25, 2020

View reviewed changes

tools/toolchains/mbed_toolchain.py Outdated Show resolved Hide resolved

tools/toolchains/mbed_toolchain.py Outdated Show resolved Hide resolved

tools/toolchains/mbed_toolchain.py Outdated Show resolved Hide resolved

mark-edgeworth previously approved these changes Mar 25, 2020

View reviewed changes

mark-edgeworth approved these changes Mar 25, 2020

View reviewed changes

mark-edgeworth previously requested changes Mar 25, 2020

View reviewed changes

hugueskamba force-pushed the hk_replace_small_lib_with_std_lib branch 2 times, most recently from 28d8665 to 7d57bdf Compare March 25, 2020 14:51

mark-edgeworth previously approved these changes Mar 25, 2020

View reviewed changes

evedon previously approved these changes Mar 25, 2020

View reviewed changes

adbridge removed the needs: work label Mar 26, 2020

Replace small with std C lib if not supported by a target's toolchain

0e5b71f

Display a post-build warning indicating to the user that the standard C library was used instead of the small C library if the former is not supported.

hugueskamba force-pushed the hk_replace_small_lib_with_std_lib branch from 7d57bdf to 0e5b71f Compare March 31, 2020 10:37

evedon approved these changes Apr 2, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: work labels Apr 2, 2020

0xc0170 added ready for merge release-version: 6.0.0-beta-1 and removed mergify skip needs: CI labels Apr 15, 2020

0xc0170 merged commit 9835722 into ARMmbed:master Apr 15, 2020

mergify bot removed the ready for merge label Apr 15, 2020

hugueskamba mentioned this pull request Apr 15, 2020

Added Mbed 2 to Mbed OS bare metal porting guide ARMmbed/mbed-os-5-docs#1293

Merged

evedon mentioned this pull request Apr 20, 2020

Override c_lib to small for all targets #12833

Merged

hugueskamba deleted the hk_replace_small_lib_with_std_lib branch June 30, 2020 11:39

Replace small with std C lib if not supported by a target's toolchain #12691

Replace small with std C lib if not supported by a target's toolchain #12691

Uh oh!

Conversation

hugueskamba commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Mar 24, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mark-edgeworth Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mark-edgeworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mark-edgeworth Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

hugueskamba Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hugueskamba commented Mar 25, 2020

Uh oh!

evedon left a comment

Choose a reason for hiding this comment

Uh oh!

evedon commented Mar 31, 2020

Uh oh!

hugueskamba commented Mar 31, 2020

Uh oh!

evedon commented Apr 1, 2020

Uh oh!

evedon left a comment

Choose a reason for hiding this comment

Uh oh!

adbridge commented Apr 2, 2020

Uh oh!

mbed-ci commented Apr 2, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Apr 3, 2020

Uh oh!

evedon commented Apr 6, 2020

Uh oh!

0xc0170 commented Apr 6, 2020

Uh oh!

0xc0170 commented Apr 9, 2020

Uh oh!

mbed-ci commented Apr 9, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Apr 9, 2020

Uh oh!

mbed-ci commented Apr 9, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Apr 14, 2020

Uh oh!

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Uh oh!

Uh oh!

hugueskamba commented Mar 24, 2020 •

edited

Loading

hugueskamba Mar 25, 2020 •

edited

Loading