Skip to content

Fix WIFI-GET-RSSI test case failure and remove extra label from CYW9P62S1_43438EVB_01 in target.json #12769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

miteshdedhia7
Copy link

@miteshdedhia7 miteshdedhia7 commented Apr 7, 2020

Summary of changes

Minor fixes

  • Remove an assert from get_rssi() in WhdSTAInterface.cpp which causes rssi greentea test to fail in Cypress parts. This is because the RSSI GT test expect the negative test case to return 0 and not assert.
  • Remove extraneous label from CYW9P62S1_43438EVB_01 target to include CM0p firmware image that has been updated to be included using the component mechanism.

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Regular Greentea Results:
GT_FT_KIT_062S2_43012_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_PROTO_062_4343W_GCC.txt
GT_FT_PROTO_062S3_4343W.txt
GT_FT_PROTO_063_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_KIT_062_BLE_GCC.txt

Network/Netsocket Test Results:
GT_FT_P6S1_43012EVB_01_GCC_NET.txt
GT_FT_PROTO_062S3_4343W_GCC_NET.txt
GT-FT-KIT_062_WIFI_BT-GCC-NET.txt
GT-FT-KIT-062S2-43012-GCC-NET.txt
GT-FT-PROT-062-4343W-GCC-NET.txt
GT_FT_KIT_EVB_43012_GCC-NET.txt

Test failures and explanations:

  • All sleep failures are expected due to to a known incompatibility between the sleep tests and our UART driver.
  • The failures with the features-storage-tests-filesystem-general_filesystem and tests-integration-stress-net-fs(only fails on CY8CPROTO_062S3_4343W board) are newly introduced on master and are being actively worked-on to fix. These are unrelated to the changes in this PR.
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@morser499 @maclobdell


cypress-midd and others added 2 commits April 7, 2020 10:42
…rssi greentea test to fail in Cypress parts. This is because the rssi GT test expect the negative test case to return 0 and not assert.
…updated to be included using the component mechanism.
@ciarmcom ciarmcom requested review from maclobdell, morser499 and a team April 7, 2020 19:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 7, 2020

@miteshdedhia7, thank you for your changes.
@morser499 @maclobdell @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-ipcore please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2020

Restarted travis to report status back, will schedule CI once we complete 5.15 Prs

0xc0170 added a commit that referenced this pull request Apr 8, 2020
@0xc0170 0xc0170 closed this Apr 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2020

Travis did not report, I'll reopen this one in a minute

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 05dd4ce into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants