Cypress: Partial backport of #12769 #12771
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assert in WhdSTAInterface.cpp causes rssi greentea test to fail on Cypress parts. This is because the rssi GT test expects the negative test case to return 0 and not assert.
|
@kyle-cypress, thank you for your changes. |
0xc0170
approved these changes
Apr 8, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 10 test jobs failed Failed test jobs:
|
|
example restarted |
|
@0xc0170 this is out of date with the base branch so shouldn't be ready for merge ? |
adbridge
approved these changes
Apr 8, 2020
adbridge
added
release-version: 5.15.2
ready for merge
and removed
Release review required
needs: work
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove an assert from get_rssi() in WhdSTAInterface.cpp which causes rssi greentea test to fail in Cypress parts. This is because the RSSI GT test expect the negative test case to return 0 and not assert.
This is a backport of 0504873 from #12769
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
GT_FT_KIT_EVB_43012_GCC-NET.txt
GT_FT_P6S1_43012EVB_01_GCC_NET.txt
GT_FT_PROTO_062S3_4343W_GCC_NET.txt
GT-FT-KIT_062_WIFI_BT-GCC-NET.txt
GT-FT-KIT-062S2-43012-GCC-NET.txt
GT-FT-PROT-062-4343W-GCC-NET.txt
The failure of test-network-wifi on CY8CKIT_062_WIFI_BT is a transient network issue; it did not repeat when the test was rerun manually.
Reviewers