Cordio: Apply Packetcraft's fix for possible SweynTooth vulnerabilities #12785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is provided by Packetcraft (which maintains the Cordio BLE stack) to address possible Sweyntooth vulnerabilities.
This change is provided by Packetcraft (which maintains the Cordio BLE stack) to address possible Sweyntooth vulnerabilities.
|
@LDong-Arm, thank you for your changes. |
0xc0170
approved these changes
Apr 9, 2020
donatieng
approved these changes
Apr 14, 2020
|
CI started |
|
@ARMmbed/mbed-os-maintainers can you not merge this yet, PacketCraft will sanity check it first :) |
|
Approved by PacketCraft, merge away! ;) |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
|
@0xc0170 can we see if mergify can port this to 5.15? If not then @LDong-Arm will need to supply a dedicated patch... |
|
@Mergifyio backport mbed-os-5.15 |
|
Command
|
|
Failed, I'll try it manually now meanwhile I talk t o @LDong-Arm |
|
#12845 created |
|
Dear all. Thanks for creating the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Packetcraft, the company that maintains the Cordio BLE stack, has assessed possible SweynTooth vulnerabilities - the only part of SweynTooth that potentially impacts Cordio is LTK Zero Installation and it takes the form of STK in our case.
This PR applies the fix (Build 1227 and Build 1233) from Packetcraft.
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Manual testing: BLE_SM (relevant to this PR) and BLE_HeartRate (randomly picked) examples behave the same ways as before, on NRF52840_DK and DISCO_L475VG_IOT01A, compiled with ARM and GCC_ARM toolchains.
Reviewers
@ARMmbed/mbed-os-pan @evedon