Skip to content

Backport SweynTooth fix for Cordio to 5.15 #12845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2020
Merged

Backport SweynTooth fix for Cordio to 5.15 #12845

merged 2 commits into from
Apr 22, 2020

Conversation

LDong-Arm
Copy link
Contributor

Summary of changes

Backport (cherry-pick) SweynTooth fix for Cordio (#12785) to Mbed OS 5.15.

Impact of changes

Migration actions required

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Manual testing: Compile and run BLE_SM example.

Reviewers

@0xc0170

@LDong-Arm
Port Cordio SMP control block improvements from Packetcraft
421becc 
This change is provided by Packetcraft (which maintains the
Cordio BLE stack) to address possible Sweyntooth vulnerabilities.

(cherry picked from commit 0402fe4)
@LDong-Arm
Port Cordio LE Secure Connections check from PacketCraft
568c1f9 
This change is provided by Packetcraft (which maintains the
Cordio BLE stack) to address possible Sweyntooth vulnerabilities.

(cherry picked from commit c927773)
@LDong-Arm LDong-Arm mentioned this pull request Apr 22, 2020
Merged
@0xc0170 0xc0170 requested a review from andypowers April 22, 2020 10:07
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 22, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Apr 22, 2020
@mbed-ci
Copy link

mbed-ci commented Apr 22, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 22, 2020

test rerun

andypowers
andypowers approved these changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 22, 2020

restarted entire CI

@mergify mergify bot added needs: work and removed needs: CI labels Apr 22, 2020
@mbed-ci
Copy link

mbed-ci commented Apr 22, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 22, 2020

Investigating why this example is suddenly failing

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 22, 2020

@ARMmbed/mbed-os-test ^^

@0xc0170 0xc0170 merged commit 61c5c74 into ARMmbed:mbed-os-5.15 Apr 22, 2020
@mergify mergify bot removed the ready for merge label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LDong-Arm @0xc0170 @mbed-ci @andypowers