Skip to content

enable common tickers & lp_tickers hal tests in baremetal mode #12827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2020
Merged

enable common tickers & lp_tickers hal tests in baremetal mode #12827

merged 1 commit into from
Apr 21, 2020

Conversation

ithinuel
Copy link
Member

@ithinuel ithinuel commented Apr 17, 2020 •
edited
Loading

Summary of changes

This enables the mbed_hal greentea tests to run in the baremetal mode.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team April 17, 2020 15:00
@ciarmcom
Copy link
Member

@ithinuel, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Apr 20, 2020
@0xc0170 0xc0170 requested review from a team and removed request for a team April 20, 2020 09:36
rajkan01
rajkan01 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please use the latest template for PR description

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2020

@ithinuel Please update the first comment (using latest template, your branch might have been older or?) - the PR template should look differently.

Test is expected to fail, there is a regression on master, will restart

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@ithinuel
Copy link
Member Author

@0xc0170 I edited the description; hope I did not mess it this time 😄

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mbed-ci
Copy link

mbed-ci commented Apr 21, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit bb6345e into ARMmbed:master Apr 21, 2020
@mergify mergify bot removed the ready for merge label Apr 21, 2020
@LDong-Arm LDong-Arm mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 rajkan01 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ithinuel @ciarmcom @0xc0170 @mbed-ci @rajkan01