-
Notifications
You must be signed in to change notification settings - Fork 3k
MultiTech mDot: use mbed tools to merge bootloader and application. #12918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ector table in system_clock.c
…nd add bootloader support.
…_dot function from tools.
@theckmts, thank you for your changes. |
@theckmts this targets 5.15 due to master cleanup (target present only on 5.15) ? |
@0xc0170 The intention is to get this change into a release of 5.15. Changes to our library for MDot/XDot require changing the bootloader and we'd prefer to target 5.15 for now and update our library to target mbed-os 6 later. If I set this to PR to target the wrong branch, please let me know what I should have done. Thanks. |
Understood, thanks ! I'll mark it as 5.15.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine to me. I'll need to although now find out what it means this tools update to the next release
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Looking at the scope for this, this is not a bugfix that could go into 5.15 branch. cc @maclobdell lets discuss this one |
We're currently working on integrating with mbed-os-6.0.0-beta-1 which already has the changes needed for our next release. I'll close this PR once we're confident with the integration. These changes will no longer be needed if mbed-os-6 works for us. |
@theckmts - after you have tested it with master (aka Mbed 6) can you make a PR to the master branch? |
Changes for mbed-os 6 were merge in 12765. We've moved to using mbed-os 6 so this PR is no longer needed and can be closed. |
Summary of changes
Removes MTS_MDOT_F411RE bootloader from tools/bootloaders and modifies the MTS_MDOT_F411RE definition in targets/targets.json so a bootloader can be specified in mbed_app.json and merged with an application using mbed cli tools.
This change is needed so the mDot bootloader can be maintained independently of mbed-os and allow users to choose their own bootloader.
Impact of changes
Existing projects targeting MTS_MDOT_F411RE that want to continue using the MTS bootloader will need to be modified to include it in their configuration settings.
Migration actions required
Documentation
None
Pull request type
Test results
Tested compiling with GCC_ARM, ARMC6, and IAR compilers using mbed cli tools.
For each compiler, verified bootloader is merged with application, application runs as expected, and bootloader version is correct.
GCC_ARM compiler output
ARMC6 compiler output
IAR compiler output
Reviewers