Skip to content

STM32F412 bypass PLL configuration when already done by bootloader #12996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2020
Merged

STM32F412 bypass PLL configuration when already done by bootloader #12996

merged 2 commits into from
Jun 5, 2020

Conversation

pilotak
Copy link
Contributor

@pilotak pilotak commented May 19, 2020

Summary of changes

fixes STM32F412 SetSysClock failed #12993

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

jeromecoutant
jeromecoutant approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe system_clock.c file could be moved down in TARGET_STM32F412xG in order to be common ?

@ciarmcom ciarmcom requested review from jeromecoutant and a team May 19, 2020 11:00
@ciarmcom
Copy link
Member

@pilotak, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

@pilotak
Copy link
Contributor Author

pilotak commented May 19, 2020

@jeromecoutant good idea

@mergify mergify bot added needs: CI and removed needs: review labels May 19, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 25, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@pilotak
Copy link
Contributor Author

pilotak commented May 28, 2020

@0xc0170 i guess this can be merged...

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 5, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2020

@0xc0170 i guess this can be merged...

Yes, sorry for the delay due to 6.0 release

@0xc0170 0xc0170 merged commit 3ef2b16 into ARMmbed:master Jun 5, 2020
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Jun 5, 2020
@mergify
Copy link

mergify bot commented Jun 5, 2020

This PR does not contain release version label after merging.

@jeromecoutant jeromecoutant mentioned this pull request Jun 5, 2020
Closed
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pilotak @ciarmcom @0xc0170 @mbed-ci @jeromecoutant @adbridge