Ensure all overridden virtual functions are marked with override
#13042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugueskamba, thank you for your changes. |
kjbracey
reviewed
Jun 1, 2020
features/lwipstack/LWIPStack.h
Outdated
| @@ -341,7 +341,7 @@ class LWIP : public OnboardNetworkStack, private mbed::NonCopyable<LWIP> { | |||
| nsapi_error_t add_dns_server(const SocketAddress &address, const char *interface_name) override; | |||
|
|
|||
| /** @copydoc NetworkStack::get_ip_address */ | |||
| virtual nsapi_error_t get_ip_address(SocketAddress *address); | |||
| virtual nsapi_error_t get_ip_address(SocketAddress *address) override; | |||
There was a problem hiding this comment.
Style preference is to drop the virtual - only use one of virtual, override, final. (Even though each implies the previous). https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rh-override
That's the way the rest of the file is written.
This also removes warnings.
hugueskamba
force-pushed
the
hk_override_warning_fix
branch
from
940063b to
1beb8d3
Compare
kjbracey
approved these changes
Jun 1, 2020
0xc0170
approved these changes
Jun 2, 2020
|
CI started |
Test run: SUCCESSSummary: 7 of 7 test jobs passed |
mergify
bot
added
release version missing
|
This PR does not contain release version label after merging. |
adbridge
added
release-version: 6.1.0
Release-pending
and removed
release-type: patch
0xc0170
removed
the
release version missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This also removes warnings.
Impact of changes
N/A
Migration actions required
N/A
Documentation
N/A
Pull request type
Test results
Reviewers
@kjbracey-arm