Skip to content

Ensure all overridden virtual functions are marked with override #13042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Ensure all overridden virtual functions are marked with override #13042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/lwipstack/LWIPStack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ class LWIP : public OnboardNetworkStack, private mbed::NonCopyable<LWIP> {
nsapi_error_t add_dns_server(const SocketAddress &address, const char *interface_name) override;

/** @copydoc NetworkStack::get_ip_address */
virtual nsapi_error_t get_ip_address(SocketAddress *address);
nsapi_error_t get_ip_address(SocketAddress *address) override;

/** @copydoc NetworkStack::get_ip_address_if */
nsapi_error_t get_ip_address_if(SocketAddress *address, const char *interface_name) override;
Expand Down
2 changes: 1 addition & 1 deletion features/nanostack/nanostack-interface/Nanostack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class Nanostack : public OnboardNetworkStack, private mbed::NonCopyable<Nanostac
/* Local variant with stronger typing and manual address specification */
nsapi_error_t add_ppp_interface(PPP &ppp, bool default_if, Nanostack::PPPInterface **interface_out);

nsapi_error_t remove_ppp_interface(OnboardNetworkStack::Interface **interface_out);
nsapi_error_t remove_ppp_interface(OnboardNetworkStack::Interface **interface_out) override;

protected:

Expand Down
2 changes: 1 addition & 1 deletion features/netsocket/ppp/ppp_service.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class ppp_service final : public PPP {
* @param uname User name
* @param password Password
*/
void set_credentials(const char *uname, const char *password);
void set_credentials(const char *uname, const char *password) override;

/** Gets local IP address
*
Expand Down