Skip to content

Feature cordio update 20 05 #13217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jul 9, 2020
Merged

Feature cordio update 20 05 #13217

merged 39 commits into from
Jul 9, 2020

Conversation

pan-
Copy link
Member

@pan- pan- commented Jul 1, 2020

Summary of changes

Update of the Cordio controller and LL stack to the version 20.05. This version of the stack is BT 5.2 certified.
However for resource usage, BT5.2 features are disabled by the mbed os integration.

Impact of changes

From a behavior standpoint, the change should be invisible for users of BLE API. However the latest version of the Cordio stack consumes more flash and more RAM:

  • ~5% increase in flash consumption (+10kB).
  • ~6% increase in RAM consumption (+1.3kB).

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@donatieng @paul-szczepanek-arm


@mergify
Copy link

mergify bot commented Jul 1, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot added the needs: work label Jul 1, 2020
@ciarmcom ciarmcom requested review from donatieng, paul-szczepanek-arm and a team July 1, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 1, 2020

@pan-, thank you for your changes.
@paul-szczepanek-arm @donatieng @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2020

After rebasing, please also update:

Update of the Cordio controller and LL stack to the latest versions.

What version are we getting. Is this just a patch bump (cordio also is just version bump or not) ?

@pan- pan- force-pushed the feature-cordio-update-20-05 branch from 8197b48 to c3a39e9 Compare July 2, 2020 16:06
@paul-szczepanek-arm
Copy link
Member

I can't edit the description but it's a 20.05 release (old one was 19.2 I think) which is more than a patch, it has new ble 5.2 features but these are not yet enabled.

@ghost
Copy link

ghost commented Jul 3, 2020

The changes might be invisible API wise, but I hope the changelog description mentions any differences in resource usage if there are any.

@pan-
Copy link
Member Author

pan- commented Jul 6, 2020

@jrobeson It affects memory consumption, I updated the description with some numbers when all the features are enabled. Depending on the features enabled, impact on code size and RAM usage may be lower.

@pan-
Copy link
Member Author

pan- commented Jul 6, 2020

@0xc0170 I have updated the description and provided some numbers for the visible changes in binary size.
@paul-szczepanek-arm @donatieng Can you review the PR ?

Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (haven't reviewed the stack/LL changes themselves but looked at the integration). @ARMmbed/mbed-os-maintainers would you be able to start the CI while awaiting @paul-szczepanek-arm?

@mergify mergify bot added needs: CI and removed needs: review labels Jul 8, 2020
@paul-szczepanek-arm
Copy link
Member

I would be reviewing my own code. I can do it, although it would be valuable for someone else to look at it as well.

@mbed-ci
Copy link

mbed-ci commented Jul 8, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2020

I'll review shortly so this can get in today if no objections.

@donatieng
Copy link
Contributor

Thanks @0xc0170 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants