-
Notifications
You must be signed in to change notification settings - Fork 3k
Feature cordio update 20 05 #13217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature cordio update 20 05 #13217
Conversation
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
@pan-, thank you for your changes. |
After rebasing, please also update:
What version are we getting. Is this just a patch bump (cordio also is just version bump or not) ? |
8197b48
to
c3a39e9
Compare
I can't edit the description but it's a 20.05 release (old one was 19.2 I think) which is more than a patch, it has new ble 5.2 features but these are not yet enabled. |
The changes might be invisible API wise, but I hope the changelog description mentions any differences in resource usage if there are any. |
create a random static address using random data
@jrobeson It affects memory consumption, I updated the description with some numbers when all the features are enabled. Depending on the features enabled, impact on code size and RAM usage may be lower. |
@0xc0170 I have updated the description and provided some numbers for the visible changes in binary size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (haven't reviewed the stack/LL changes themselves but looked at the integration). @ARMmbed/mbed-os-maintainers would you be able to start the CI while awaiting @paul-szczepanek-arm?
I would be reviewing my own code. I can do it, although it would be valuable for someone else to look at it as well. |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
I'll review shortly so this can get in today if no objections. |
Thanks @0xc0170 ! |
Summary of changes
Update of the Cordio controller and LL stack to the version 20.05. This version of the stack is BT 5.2 certified.
However for resource usage, BT5.2 features are disabled by the mbed os integration.
Impact of changes
From a behavior standpoint, the change should be invisible for users of BLE API. However the latest version of the Cordio stack consumes more flash and more RAM:
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@donatieng @paul-szczepanek-arm