Skip to content

CMake: Create mbed-greentea library #14061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Dec 16, 2020

Summary of changes

The greentea framework provides all the infrastructure for the test suite to execute in the target like greentea-client, unity, utest so created the mbed-greentea interface library which binds all these framework sources, and all the test suite needs to add mbed-greentea lib into their target_link_library

Impact of changes

None.

Migration actions required

None.

Documentation

None.


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba @0xc0170


@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@hugueskamba @0xc0170 @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbed-greentea consists of unity and utest as well? I did not check but unity is own library (or there are deps) ?

if greentea just links to unity + utest ?

@rajkan01
Copy link
Contributor Author

rajkan01 commented Dec 17, 2020

mbed-greentea consists of unity and utest as well? I did not check but unity is own library (or there are deps) ?

if greentea just links to unity + utest ?

@0xc0170 Yes, unity can be own library, but utest has a dependency on unity and Mbed OS Singleton, Timeout etc.,.
greentea client + unity + utest are all together providing greentea template for test suite and greentea links unity + utest + mbed-os lib

@rajkan01 rajkan01 requested a review from 0xc0170 December 17, 2020 19:21
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2020

What tests need to include is mbed-greentea + mbed-os/baremetal, that is it to work?

@mergify mergify bot added needs: CI and removed needs: review labels Dec 18, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2020

CI started

@rajkan01
Copy link
Contributor Author

What tests need to include is mbed-greentea + mbed-os/baremetal, that is it to work?

@0xc0170 yes, test CMakeLists.txt target link libraries with mbed-greentea + mbed-os/mbed-barematel with additional libraries based on the component which is trying to test

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants