STM32F4 update drivers version to CUBE V1.26.0 #14339

jeromecoutant · 2021-02-24T11:16:59Z

Summary of changes

ST Cube drivers version is updated from V1.25.0 to V1.26.0
which is the latest official version from:

https://github.com/STMicroelectronics/STM32CubeF4/

@ARMmbed/team-st-mcd

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2021-02-24T11:30:20Z

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

ciarmcom · 2021-02-28T12:50:22Z

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

jeromecoutant · 2021-03-09T10:06:24Z

@0xc0170 ping

0xc0170 · 2021-03-09T17:38:16Z

CI started

mbed-ci · 2021-03-09T19:23:38Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️

jeromecoutant · 2021-03-10T07:38:43Z

jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌

I think issue is stm32f401xe.ld file name is STM32F401XE.ld
It's working on my side because I am with Windows, I suppose your CI machine is linux....

I change the name in my branch, my git doesn't see the change.... :-(

Pull request has been modified.

jeromecoutant · 2021-03-10T07:48:40Z

@0xc0170 Maybe I found some ignorecase option.
Could you restart CI ?

adbridge · 2021-03-10T13:42:19Z

CI restarted

0xc0170 · 2021-03-11T11:32:59Z

CI started

mbed-ci · 2021-03-11T13:24:09Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

boraozgen · 2021-05-03T12:42:50Z

targets/TARGET_STM/TARGET_STM32F4/STM32Cube_FW/system_stm32f4xx.c

@@ -147,7 +166,7 @@ const uint8_t APBPrescTable[8]  = {0, 0, 0, 0, 1, 2, 3, 4};
  * @param  None
  * @retval None
  */
-__weak void SystemInit(void)
+void SystemInit(void)


__weak removed - breaks custom targets with custom initialization

@JeanMarcR
Can you add it back in #14548 ?

How did this happen, @jeromecoutant ? Is the system init not weak in the drivers or is this done only for Mbed ?

Yes, system init is not weak in the ST original files,
and OK for "basic" nucleo or disco boards.

I understand that some custom boards would need to change it.

jeromecoutant mentioned this pull request Feb 24, 2021

STM32L4 : align CMakeLists.txt with all STM32 #14293

Merged

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 24, 2021

ciarmcom requested a review from a team February 24, 2021 11:30

ciarmcom added needs: review devices: st stale Stale Pull Request labels Feb 24, 2021

jeromecoutant force-pushed the PR_F4_1260 branch from 6bfa10d to f69988a Compare March 9, 2021 10:05

0xc0170 previously approved these changes Mar 9, 2021

View reviewed changes

mergify bot added needs: CI needs: work and removed needs: review needs: CI labels Mar 9, 2021

jeromecoutant added 8 commits March 10, 2021 08:45

STM32F4: align CMakeLists.txt for all families

3d1d3b7

STM32F4: move TARGET_MTS_DRAGONFLY_F411RE info STM32F411xE

bccef1a

STM32F4: move TARGET_MTS_MDOT_F411RE info STM32F411xE

82a3178

STM32F4 : add subfamilies in targets.json

6e90fd2

STM32F4: move common files

de27e83

STM32F4: license header alignment

338e37a

STM32F4: STM32Cube_FW_F4_V1.26.0 - STM32Cube_FW

021aa00

STM32F4: STM32Cube_FW_F4_V1.26.0 - Subfamilies

c41ea5f

jeromecoutant force-pushed the PR_F4_1260 branch from f69988a to c41ea5f Compare March 10, 2021 07:47

0xc0170 added needs: CI and removed needs: work stale Stale Pull Request labels Mar 11, 2021

0xc0170 approved these changes Mar 11, 2021

View reviewed changes

0xc0170 merged commit eec320c into ARMmbed:master Mar 11, 2021

0xc0170 removed the needs: CI label Mar 11, 2021

This was referenced Mar 12, 2021

Bump mbed-os from f227856 to eec320c uwrobotics/MarsRoverFirmware#321

Closed

Bump mbed-os from f227856 to eec320c WolfgangWindholtz/MarsRover2020-firmware#43

Closed

jeromecoutant deleted the PR_F4_1260 branch March 12, 2021 07:39

mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021

boraozgen reviewed May 3, 2021

View reviewed changes

jeromecoutant mentioned this pull request May 31, 2022

STMF411RE - configuring an external 26MHz clock source #15290

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

STM32F4 update drivers version to CUBE V1.26.0 #14339

STM32F4 update drivers version to CUBE V1.26.0 #14339

Uh oh!

jeromecoutant commented Feb 24, 2021

Uh oh!

ciarmcom commented Feb 24, 2021

Uh oh!

ciarmcom commented Feb 28, 2021

Uh oh!

jeromecoutant commented Mar 9, 2021

Uh oh!

0xc0170 commented Mar 9, 2021

Uh oh!

mbed-ci commented Mar 9, 2021

Uh oh!

jeromecoutant commented Mar 10, 2021

Uh oh!

jeromecoutant commented Mar 10, 2021

Uh oh!

adbridge commented Mar 10, 2021

Uh oh!

0xc0170 commented Mar 11, 2021

Uh oh!

mbed-ci commented Mar 11, 2021

Uh oh!

boraozgen May 3, 2021

Uh oh!

jeromecoutant May 3, 2021

Uh oh!

0xc0170 May 3, 2021

Uh oh!

jeromecoutant May 3, 2021

Uh oh!

Uh oh!

STM32F4 update drivers version to CUBE V1.26.0 #14339

STM32F4 update drivers version to CUBE V1.26.0 #14339

Uh oh!

Conversation

jeromecoutant commented Feb 24, 2021

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Feb 24, 2021

Uh oh!

ciarmcom commented Feb 28, 2021

Uh oh!

jeromecoutant commented Mar 9, 2021

Uh oh!

0xc0170 commented Mar 9, 2021

Uh oh!

mbed-ci commented Mar 9, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

jeromecoutant commented Mar 10, 2021

Uh oh!

jeromecoutant commented Mar 10, 2021

Uh oh!

adbridge commented Mar 10, 2021

Uh oh!

0xc0170 commented Mar 11, 2021

Uh oh!

mbed-ci commented Mar 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

boraozgen May 3, 2021

Choose a reason for hiding this comment

Uh oh!

jeromecoutant May 3, 2021

Choose a reason for hiding this comment

Uh oh!

0xc0170 May 3, 2021

Choose a reason for hiding this comment

Uh oh!

jeromecoutant May 3, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!