Added support for C027. Small re-factor to LPC1768 to accommodate this. #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gpio_t led_red; gpio_init(&led_red, LED_RED, PIN_OUTPUT); | ||
|
|
||
| #elif defined(DEVICE_ERROR_PATTERN) | ||
| #elif (DEVICE_ERROR_PATTERN == 1) |
There was a problem hiding this comment.
Not sure why you needed this change? It doesn't seem to change anything functionally (correct me if I'm wrong) and it's not consistent with the rest of the code (right above, there is an #if defined(DEVICE_ERROR_RED) that doesn't explicitily test the value of DEVICE_ERROR_RED).
…n mbed_main and fixed copy paste error in MBED_LPC1768 reserved_pins.h
|
Updated copy paste errors and trying a new way to init hardware before main. thoughts? |
|
I can't see anything related to hardware initialization in this new pull request, which means that I can merge it in now :) Thanks! |
|
Merged manually. |
yossi2le
pushed a commit
to yossi2le/mbed-os
that referenced
this pull request
Jan 2, 2019
Add tutorial for changing various settings.
Jookia
pushed a commit
to Jookia/mbed-os
that referenced
this pull request
May 18, 2023
* Try and fix repeated start for transactional I2C API * Use OTHER_FRAME everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.