Skip to content

Fixed double-ignored files that cause python exception #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2016
Merged

Fixed double-ignored files that cause python exception #1967

merged 2 commits into from
Jun 21, 2016

Conversation

screamerbg
Copy link
Contributor

@screamerbg screamerbg commented Jun 16, 2016 •
edited
Loading

Also simplify build scanning logic and add comments

@screamerbg
Fixed double-ignored files that cause python exception
fb5c4a6 
Also simplify build scanning logic and add comments
@screamerbg
Copy link
Contributor Author

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,KL25Z

@mbed-bot
Copy link

Merged build finished. No test results found.
[Build 504]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

[Build 504]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@screamerbg
Copy link
Contributor Author

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,KL25Z

@mbed-bot
Copy link

Merged build finished. No test results found.
[Build 508]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

[Build 508]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 17, 2016

Seems like we got 2 fixes (#1966) for one bug. Please look at it ,and we should close one of them?

ignore_ptrs - I read this as ignore pointers :-) I would go with ignore_patterns.

LGTM

@0xc0170 0xc0170 mentioned this pull request Jun 17, 2016
Closed
@bridadan
Copy link
Contributor

This PR looks good after local testing.

+1

@sg-
Copy link
Contributor

sg- commented Jun 17, 2016

Should be updated per @0xc0170 suggestion: ignore_ptrs - I read this as ignore pointers :-) I would go with ignore_patterns.

@screamerbg
Copy link
Contributor Author

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,KL25Z

@mbed-bot
Copy link

[Build 511]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2016

LGTM

@sg- sg- merged commit 3a01862 into ARMmbed:master Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@screamerbg @mbed-bot @0xc0170 @bridadan @sg-