Add toolchain flag to DS-5 exporter #2330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,8 @@ class DS5_5(Exporter): | |||
| 's_sources':'2' | |||
| } | |||
|
|
|||
| TOOLCHAIN = "ARM" | |||
There was a problem hiding this comment.
The line below (46) seems to tell a slightly different story. Is it possible to replace the access to TOOLCHAIN to use get_toolchain instead?
There was a problem hiding this comment.
Yup, I definitely can. See here:https://github.com/ARMmbed/mbed-os/blob/master/tools/export/__init__.py#L97 . The TOOLCHAIN member is supposed to be a member of the class. So, I cannot make it a @property that calls self.get_toolchain as that would require a constructed object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves ARMmbed/mbed-os-example-blinky#19