Skip to content

Add toolchain flag to DS-5 exporter #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2016
+2 −0
Merged

Add toolchain flag to DS-5 exporter #2330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/export/ds5_5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ class DS5_5(Exporter):
's_sources':'2'
}

TOOLCHAIN = "ARM"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line below (46) seems to tell a slightly different story. Is it possible to replace the access to TOOLCHAIN to use get_toolchain instead?

Copy link
Contributor Author

@theotherjimmy theotherjimmy Aug 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I definitely can. See here:https://github.com/ARMmbed/mbed-os/blob/master/tools/export/__init__.py#L97 . The TOOLCHAIN member is supposed to be a member of the class. So, I cannot make it a @property that calls self.get_toolchain as that would require a constructed object.


def get_toolchain(self):
return 'uARM' if (self.target in self.USING_MICROLIB) else 'ARM'

Expand Down