Skip to content

Enable FEATURE_IPV4 for the VK_RZ_A1H #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2016
Merged

Conversation

geky
Copy link
Contributor

@geky geky commented Aug 3, 2016

VK_RZ_A1H already has lwip support and restricting FEATURE_IPV4 is unnecessary.

should fix ARMmbed/mbed-os-example-client#67
tested locally with mbed-os-example-client and the nsapi tests

cc @sg-, @bulislaw

@sg-
Copy link
Contributor

sg- commented Aug 3, 2016

@geky can you add releases for 2 and 5 in a separate commit? Then we can run CI.

@geky
Copy link
Contributor Author

geky commented Aug 3, 2016

@sg-, marked for release 👍

@sg-
Copy link
Contributor

sg- commented Aug 3, 2016

/morph test

@sg-
Copy link
Contributor

sg- commented Aug 3, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE,K22F

@mbed-bot
Copy link

mbed-bot commented Aug 3, 2016

[Build 767]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

mbed-bot commented Aug 3, 2016

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 596

Build failed!

@bridadan
Copy link
Contributor

bridadan commented Aug 3, 2016

Build failed for IAR:

16:19:18 Building project test_setup_failure (VK_RZ_A1H, IAR)
16:19:18 Scan: IAR
16:19:18 Scan: FEATURE_IPV4
16:19:19 Scan: test_setup_failure
16:19:20 Compile: main.cpp
16:19:20 Link: test_setup_failure
16:21:01 Error[Li006]: duplicate definitions for "__iar_program_start"; in "C:\Jenkins\w
16:21:01           orkspace\bm_wrap\240\.build\tests\VK_RZ_A1H\IAR\hal\targets\cmsis\TAR
16:21:01           GET_RENESAS\TARGET_VK_RZ_A1H\TOOLCHAIN_IAR\startup_VKRZA1H.o", and "C
16:21:01           :\Jenkins\workspace\bm_wrap\240\.build\tests\VK_RZ_A1H\IAR\rtos\rtx\T
16:21:01           ARGET_CORTEX_A\RTX_Conf_CA.o"

@geky
Copy link
Contributor Author

geky commented Aug 3, 2016

It looks like the entry point for the VK_RZ_A1H wasn't marked as weak.

Fixed, and succesfully compiled locally with IAR.

@geky
Copy link
Contributor Author

geky commented Aug 3, 2016

/morph test

@geky
Copy link
Contributor Author

geky commented Aug 3, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE,K22F

@mbed-bot
Copy link

mbed-bot commented Aug 3, 2016

[Build 768]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@bridadan
Copy link
Contributor

bridadan commented Aug 3, 2016

@geky I'm already seeing failure in the build for the VK_RZ_A1H for IAR:

17:58:03 Building project test_setup_failure (VK_RZ_A1H, IAR)
17:58:03 Scan: IAR
17:58:03 Scan: FEATURE_IPV4
17:58:03 Scan: test_setup_failure
17:58:03 Compile: main.cpp
17:58:03 Link: test_setup_failure
17:58:29 Error[Li005]: no definition for "__vector_core_a9" [referenced from C:\Jenkins\
17:58:29           workspace\bm_wrap\242\.build\tests\VK_RZ_A1H\IAR\rtos\rtx\TARGET_CORT
17:58:29           EX_A\RTX_Conf_CA.o]

This seems suspicious though if you were able to compile it locally. What version of IAR are you using? We are using v7.40 of the compiler in the CI.

@mbed-bot
Copy link

mbed-bot commented Aug 3, 2016

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 598

Build failed!

@geky
Copy link
Contributor Author

geky commented Aug 4, 2016

@bridadan, damn, according to my path I am also using 7.40. Does CI pre-merge with master? I'll have to figure out network-license issues to continue testing.

@bridadan
Copy link
Contributor

bridadan commented Aug 4, 2016

@geky Yeah it merges with master! For your reference, the CI merged your commit of cc97daa425cdeb52ff67f979bc8d3c1994775350 with this commit of master: 8996227

@geky geky force-pushed the add-ipv4-vk_rz_a1h branch from cc97daa to 413ea26 Compare August 4, 2016 21:37
@geky
Copy link
Contributor Author

geky commented Aug 4, 2016

Figured it out on my end, looks like I wasn't compiling all of the tests, and the issue only showed up on a few.

Compiled successfully locally with the following command:

mbed test -j1 --compile -t IAR -m VK_RZ_A1H

@geky
Copy link
Contributor Author

geky commented Aug 4, 2016

/morph test

@geky
Copy link
Contributor Author

geky commented Aug 4, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE,K22F

@mbed-bot
Copy link

mbed-bot commented Aug 4, 2016

[Build 773]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

mbed-bot commented Aug 4, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 605

All builds and test passed!

@sg- sg- merged commit 8e24d68 into ARMmbed:master Aug 5, 2016
@sg-
Copy link
Contributor

sg- commented Aug 5, 2016

LGTM 👍

artokin pushed a commit to artokin/mbed-os that referenced this pull request May 11, 2020
…..9a21668

9a21668 Merge branch 'release_internal' into release_external
8e72b80 MAC CCA thr: Check if channel out of range (ARMmbed#2363)
146a0a3 Corrected trace on authenticator
d04a96d Merge pull request ARMmbed#2361 from ARMmbed/sync_with_mbedos
2c2b915 Added empty function for ns time callback
76ac0de Remove NCS36510 target
0258ac3 Remove KW24D target
788f01b Netsocket/lwIP Stack: Remove support for ARM Compiler 5
2fbc7a1 Corrected invalid memory read on access revoke
941b9b4 Updates to stagger/latency (ARMmbed#2358)
c2abaaa Corrected defects
1811194 Corrected warning trace, validations and ut stubs
69e2d19 Added NS filesystem and interface to application
c5b6993 refactored packet ingress
a05605e Unsecured packets will be acked by default automatically.
36dfb29 MAC: Implemented automatic CCA threshold (ARMmbed#2353)
0396b97 Revert EAPOL simplify failure handling and focus this problem later on.
b2fe3d4 Ignoring authentication failure if security protocol already started
11de56d Added info API for Wi-SUN border router
87a4f69 Added EAPOL key storage to authenticator and unified GTK storage (ARMmbed#2345)
ff1ca25 EAPOL failure simplify and EAPOL relay agent add trace when eapol temp pool is empty
6667b31 Update NA trace
34cdafe Temporary EAPOL neighbour entry Update and MAC MLME update
d092f83 Iotthd 3995 (ARMmbed#2347)
e2ea4e4 Disabled BR (TLS server) EC calculation queue
5759851 Changed the rate limiting function to calculate the values runtime
899e755 Make it possible to update tr51 table to larger dynamically
8436669 Added configuration for DHCP lifetime value
da732bc When network name or PAN ID is changed authenticator updates MAC keys

git-subtree-dir: features/nanostack/sal-stack-nanostack
git-subtree-split: 9a21668
artokin pushed a commit to artokin/mbed-os that referenced this pull request Jun 8, 2020
…..b3fe574

b3fe574 Remove test files from the release
b2bf24c Merge branch 'release_internal' into release_external
0ed25a7 Fix errors found from coverity scan (ARMmbed#2386)
7a138f7 Added IID for border router info structure
4021b0c LLC secure data duplicate check update and EAPOL relay duplicate fix
b190a97 Remove Thread-protocol from README (ARMmbed#2383)
ae8ae32 EAPOL relay agent rx filter from joiner side
0d4eb7a Removed dead code part
fc644f5 RPL new parent accept update and NUD operation
f5920e2 ETX API update and RPL ETX threshold callback update.
1fdee20 Wi-sun keep all candidates alive by NUD.
bd746da Key storage settings are no longer cleared on delete
bd388fc Changed EAPOL initial-Key retries from 2 to 4 on large NW
a3d80a3 WS bootstrap: Default CCA threshold to -60dBm (ARMmbed#2377)
72b26a7 Created extra large network setup for Wi-SUN
38dd4a6 Corrected PTK and PMK lifetime handling
64f2a77 Cleared EAPOL temporary trace print's.
02ec23f Timed parent selection is now imim-imin*2 earlier there was just 5 seconds randomize.
3b2d906 Added check for network name and DODAG ID IID (EUI-64) (ARMmbed#2373)
ee45f4b Updated initial key trickles
184425b Fixed parent target address set.
07ec237 Updated Discovery and RPL setup large & medium size network
a94d8f2 RPL version num update
9e2ac1d Double default eapol entry size for test purpose.
6b8beef Clear all neighbors only on eapol next target check
faa19e1 Corrected next address set
8a917fb Continue trickle on initial EAPOL-key TX failure
cfdb193 Merge pull request ARMmbed#2368 from ARMmbed/sync_with_mbedos
f7a15fa (via MbedOS) ws: added support for brazilian regulatory domain
c397edb Changed large network initial-key trickle parameters
758f534 Added maximum frame counter storing interval
b0ea148 Corrected key storage configuration setting
be3c94e WS RPL paret soft filter update
8b1d537 Adjusted EAPOL limits and timers
9a21668 Merge branch 'release_internal' into release_external
8e72b80 MAC CCA thr: Check if channel out of range (ARMmbed#2363)
146a0a3 Corrected trace on authenticator
d04a96d Merge pull request ARMmbed#2361 from ARMmbed/sync_with_mbedos
2c2b915 Added empty function for ns time callback
76ac0de Remove NCS36510 target
0258ac3 Remove KW24D target
788f01b Netsocket/lwIP Stack: Remove support for ARM Compiler 5
2fbc7a1 Corrected invalid memory read on access revoke
941b9b4 Updates to stagger/latency (ARMmbed#2358)
c2abaaa Corrected defects
1811194 Corrected warning trace, validations and ut stubs
69e2d19 Added NS filesystem and interface to application
c5b6993 refactored packet ingress
a05605e Unsecured packets will be acked by default automatically.
36dfb29 MAC: Implemented automatic CCA threshold (ARMmbed#2353)
0396b97 Revert EAPOL simplify failure handling and focus this problem later on.
b2fe3d4 Ignoring authentication failure if security protocol already started
11de56d Added info API for Wi-SUN border router
87a4f69 Added EAPOL key storage to authenticator and unified GTK storage (ARMmbed#2345)
ff1ca25 EAPOL failure simplify and EAPOL relay agent add trace when eapol temp pool is empty
6667b31 Update NA trace
34cdafe Temporary EAPOL neighbour entry Update and MAC MLME update
d092f83 Iotthd 3995 (ARMmbed#2347)
e2ea4e4 Disabled BR (TLS server) EC calculation queue
5759851 Changed the rate limiting function to calculate the values runtime
899e755 Make it possible to update tr51 table to larger dynamically
8436669 Added configuration for DHCP lifetime value
da732bc When network name or PAN ID is changed authenticator updates MAC keys

git-subtree-dir: features/nanostack/sal-stack-nanostack
git-subtree-split: b3fe574
artokin pushed a commit to artokin/mbed-os that referenced this pull request Jun 8, 2020
…..b3fe574

b3fe574 Remove test files from the release
b2bf24c Merge branch 'release_internal' into release_external
0ed25a7 Fix errors found from coverity scan (ARMmbed#2386)
7a138f7 Added IID for border router info structure
4021b0c LLC secure data duplicate check update and EAPOL relay duplicate fix
b190a97 Remove Thread-protocol from README (ARMmbed#2383)
ae8ae32 EAPOL relay agent rx filter from joiner side
0d4eb7a Removed dead code part
fc644f5 RPL new parent accept update and NUD operation
f5920e2 ETX API update and RPL ETX threshold callback update.
1fdee20 Wi-sun keep all candidates alive by NUD.
bd746da Key storage settings are no longer cleared on delete
bd388fc Changed EAPOL initial-Key retries from 2 to 4 on large NW
a3d80a3 WS bootstrap: Default CCA threshold to -60dBm (ARMmbed#2377)
72b26a7 Created extra large network setup for Wi-SUN
38dd4a6 Corrected PTK and PMK lifetime handling
64f2a77 Cleared EAPOL temporary trace print's.
02ec23f Timed parent selection is now imim-imin*2 earlier there was just 5 seconds randomize.
3b2d906 Added check for network name and DODAG ID IID (EUI-64) (ARMmbed#2373)
ee45f4b Updated initial key trickles
184425b Fixed parent target address set.
07ec237 Updated Discovery and RPL setup large & medium size network
a94d8f2 RPL version num update
9e2ac1d Double default eapol entry size for test purpose.
6b8beef Clear all neighbors only on eapol next target check
faa19e1 Corrected next address set
8a917fb Continue trickle on initial EAPOL-key TX failure
cfdb193 Merge pull request ARMmbed#2368 from ARMmbed/sync_with_mbedos
f7a15fa (via MbedOS) ws: added support for brazilian regulatory domain
c397edb Changed large network initial-key trickle parameters
758f534 Added maximum frame counter storing interval
b0ea148 Corrected key storage configuration setting
be3c94e WS RPL paret soft filter update
8b1d537 Adjusted EAPOL limits and timers
9a21668 Merge branch 'release_internal' into release_external
8e72b80 MAC CCA thr: Check if channel out of range (ARMmbed#2363)
146a0a3 Corrected trace on authenticator
d04a96d Merge pull request ARMmbed#2361 from ARMmbed/sync_with_mbedos
2c2b915 Added empty function for ns time callback
76ac0de Remove NCS36510 target
0258ac3 Remove KW24D target
788f01b Netsocket/lwIP Stack: Remove support for ARM Compiler 5
2fbc7a1 Corrected invalid memory read on access revoke
941b9b4 Updates to stagger/latency (ARMmbed#2358)
c2abaaa Corrected defects
1811194 Corrected warning trace, validations and ut stubs
69e2d19 Added NS filesystem and interface to application
c5b6993 refactored packet ingress
a05605e Unsecured packets will be acked by default automatically.
36dfb29 MAC: Implemented automatic CCA threshold (ARMmbed#2353)
0396b97 Revert EAPOL simplify failure handling and focus this problem later on.
b2fe3d4 Ignoring authentication failure if security protocol already started
11de56d Added info API for Wi-SUN border router
87a4f69 Added EAPOL key storage to authenticator and unified GTK storage (ARMmbed#2345)
ff1ca25 EAPOL failure simplify and EAPOL relay agent add trace when eapol temp pool is empty
6667b31 Update NA trace
34cdafe Temporary EAPOL neighbour entry Update and MAC MLME update
d092f83 Iotthd 3995 (ARMmbed#2347)
e2ea4e4 Disabled BR (TLS server) EC calculation queue
5759851 Changed the rate limiting function to calculate the values runtime
899e755 Make it possible to update tr51 table to larger dynamically
8436669 Added configuration for DHCP lifetime value
da732bc When network name or PAN ID is changed authenticator updates MAC keys

git-subtree-dir: features/nanostack/sal-stack-nanostack
git-subtree-split: b3fe574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VK_RZ_A1H: fatal error: EthernetInterface.h: No such file or directory
4 participants