Add the setting to use the mbed-os-example-client #2386

TomoYamanaka · 2016-08-08T10:28:15Z

By default, mbed-os-example-client can't be built for Renesas GR-PEACH, and This is the workaround for the issue.

There is no device unique ID to the GR-PEACH. Therefore, we implimented the following function.

The value read by the Timer is set to a random seed.
Put a random number into the entropy poll, and returns it.

Regards,
Tomo Yamanaka

By default, mbed-os-example-client can't be built for Renesas GR-PEACH, and This is the workaround for the issue.

0xc0170 · 2016-08-08T11:22:03Z

Can you please fix the formatting in the hal implementation to be compatible with mbed coding style?

Why did you decide to use Timer (c++ file) , not to use us ticker HAL functions?

bridadan · 2016-08-08T16:14:22Z

hal/targets.json

@@ -1628,6 +1628,7 @@
        "extra_labels": ["RENESAS", "MBRZA1H"],
        "supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
        "inherits": ["Target"],
+        "macros": [" MBEDTLS_ENTROPY_HARDWARE_ALT "],


Nit pick: Is there a reason the extra "space" characters ( ) are needed on both sides ofMBEDTLS_ENTROPY_HARDWARE_ALT? Could the line be changed from:

"macros": [" MBEDTLS_ENTROPY_HARDWARE_ALT "],

to

"macros": ["MBEDTLS_ENTROPY_HARDWARE_ALT"],

I deleted the unnecessary space.

TomoYamanaka · 2016-08-09T01:42:37Z

hal/targets.json

@@ -1628,6 +1628,7 @@
        "extra_labels": ["RENESAS", "MBRZA1H"],
        "supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
        "inherits": ["Target"],
+        "macros": ["MBEDTLS_ENTROPY_HARDWARE_ALT"],


Thank you your comments.

I deleted the unnecessary space.

TomoYamanaka · 2016-08-09T06:25:36Z

@0xc0170

Thank you for your comments.

Can you please fix the formatting in the hal implementation to be compatible with mbed coding style?

Do you mean the current etropy_hardware_poll.cpp can't follow the following points in mbed OS 5.0 coding rules?

Space after statements of type if, while, for, switch.
Unix line endings are default option for files.
Empty lines should have no trailing spaces.

Please let me confirm your intention, just in case.

Why did you decide to use Timer (c++ file) , not to use us ticker HAL functions?

My understanding on your feedback is that the API declared in us_ticker_api.h is preferred in this case. Can I get it right?

0xc0170 · 2016-08-09T13:13:29Z

Do you mean the current etropy_hardware_poll.cpp can't follow the following points in mbed OS 5.0 coding rules?

Yes it should, mainly around if where { are on the same line, for instance.

My understanding on your feedback is that the API declared in us_ticker_api.h is preferred in this case. Can I get it right?

Yes, it's HAL implementation and I don't see why that file needs t obe c++ file (using C++ API). What do you think?

TomoYamanaka · 2016-08-10T04:37:44Z

@0xc0170

Thank you for your explanation.
I understood very well.

I'll fix again by feedback the contents.

In "etropy_hardware_poll" function, I modified to reference the API declared in us_ticker_api.h. And along the mbed OS 5.0 coding rules, I modified the code.

TomoYamanaka · 2016-08-23T08:39:16Z

@0xc0170

I fixed the code by feedback your contents.
In "etropy_hardware_poll" function, I modified to reference the API declared in us_ticker_api.h.
And along the mbed OS 5.0 coding rules, I modified the code.

0xc0170 · 2016-08-25T12:23:14Z

/morph test

0xc0170 · 2016-08-25T12:23:51Z

The code looks good, thanks for updating it. we'll wait for CI results

mbed-bot · 2016-08-25T13:56:29Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 713

All builds and test passed!

sg- · 2016-08-26T14:10:29Z

@TomoYamanaka This is meant to be inplemented by an TRNG. If the device doesn't have one you can provide a storage driver and we'll be adding a NV_SEED based implementation for mbed OS 5.2.

Alternatively, until later this year you can use no entropy by adding the following define to an application. https://github.com/ARMmbed/mbed-os-example-client#requirements-for-non-k64f-board

@sbutcher-arm

TomoYamanaka · 2016-08-29T06:47:35Z

@sg-

Thank you for your clarification.
Could you inform me of a little more detail schedule for "mbed OS 5.2" ?

I have the opportunity in which mbed Client is must-have function.
If I would enable "MBEDTLS_TEST_NULL_ENTROPY", it might be impact to it.
So, I would like to clarify the schedule for "mbed OS 5.2" for further consideration.

Also, I'm not sure what the "storage driver" is.
Could you inform me of the supplementary information on it?

Osamu-Nakamura · 2016-09-07T07:40:28Z

@sg-

I have a question on the usage of no entropy. When I tried no entropy in accordance with https://github.com/ARMmbed/mbed-os-example-client#requirements-for-non-k64f-board, I faced a compiling error. It seems that MBEDTLS_NO_DEFAULT_ENTROPY_SOURCES isn't defined in mbed_config.h in the problem case and it caused an error. Instead, if I added MBEDTLS_NO_DEFAULT_ENTROPY_SOURCES and MBEDTLS_TEST_NULL_ENTROPY to targets.json, I could successfully build the program.

Is any additional procedure needed when modifying mbed_app.json?

sg- · 2016-09-08T22:11:45Z

Both macros MBEDTLS_NO_DEFAULT_ENTROPY_SOURCES and MBEDTLS_TEST_NULL_ENTROPY should be added to the mbed_app.json file

toyowata · 2016-09-16T15:29:08Z

@sg-
I think current example of mbed_app.json for the K64F boards is not correct and created the ticket here: ARMmbed/mbed-os-example-client#84

sg- · 2016-09-28T02:58:46Z

The mbed TLS entropy integration is done via TRNG HAL. If the device supports TRNG that is the way to enable.

sg- · 2016-11-11T14:51:08Z

NV_SEED didn't make it into mbed OS 5.2 Will provide more updates when available.

Osamu-Nakamura · 2016-11-21T08:39:20Z

We Renesas strongly hope NV_SEED is supported in the near future update (i.e. mbed OS 5.3 or mbed OS 5.4). Otherwise, we cannot help providing users with poor security. It should be disadvantage for both you and us. Please take this point into consideration. Thank you for your understanding.

…..b3fe574 b3fe574 Remove test files from the release b2bf24c Merge branch 'release_internal' into release_external 0ed25a7 Fix errors found from coverity scan (ARMmbed#2386) 7a138f7 Added IID for border router info structure 4021b0c LLC secure data duplicate check update and EAPOL relay duplicate fix b190a97 Remove Thread-protocol from README (ARMmbed#2383) ae8ae32 EAPOL relay agent rx filter from joiner side 0d4eb7a Removed dead code part fc644f5 RPL new parent accept update and NUD operation f5920e2 ETX API update and RPL ETX threshold callback update. 1fdee20 Wi-sun keep all candidates alive by NUD. bd746da Key storage settings are no longer cleared on delete bd388fc Changed EAPOL initial-Key retries from 2 to 4 on large NW a3d80a3 WS bootstrap: Default CCA threshold to -60dBm (ARMmbed#2377) 72b26a7 Created extra large network setup for Wi-SUN 38dd4a6 Corrected PTK and PMK lifetime handling 64f2a77 Cleared EAPOL temporary trace print's. 02ec23f Timed parent selection is now imim-imin*2 earlier there was just 5 seconds randomize. 3b2d906 Added check for network name and DODAG ID IID (EUI-64) (ARMmbed#2373) ee45f4b Updated initial key trickles 184425b Fixed parent target address set. 07ec237 Updated Discovery and RPL setup large & medium size network a94d8f2 RPL version num update 9e2ac1d Double default eapol entry size for test purpose. 6b8beef Clear all neighbors only on eapol next target check faa19e1 Corrected next address set 8a917fb Continue trickle on initial EAPOL-key TX failure cfdb193 Merge pull request ARMmbed#2368 from ARMmbed/sync_with_mbedos f7a15fa (via MbedOS) ws: added support for brazilian regulatory domain c397edb Changed large network initial-key trickle parameters 758f534 Added maximum frame counter storing interval b0ea148 Corrected key storage configuration setting be3c94e WS RPL paret soft filter update 8b1d537 Adjusted EAPOL limits and timers git-subtree-dir: features/nanostack/sal-stack-nanostack git-subtree-split: b3fe574

…..b3fe574 b3fe574 Remove test files from the release b2bf24c Merge branch 'release_internal' into release_external 0ed25a7 Fix errors found from coverity scan (ARMmbed#2386) 7a138f7 Added IID for border router info structure 4021b0c LLC secure data duplicate check update and EAPOL relay duplicate fix b190a97 Remove Thread-protocol from README (ARMmbed#2383) ae8ae32 EAPOL relay agent rx filter from joiner side 0d4eb7a Removed dead code part fc644f5 RPL new parent accept update and NUD operation f5920e2 ETX API update and RPL ETX threshold callback update. 1fdee20 Wi-sun keep all candidates alive by NUD. bd746da Key storage settings are no longer cleared on delete bd388fc Changed EAPOL initial-Key retries from 2 to 4 on large NW a3d80a3 WS bootstrap: Default CCA threshold to -60dBm (ARMmbed#2377) 72b26a7 Created extra large network setup for Wi-SUN 38dd4a6 Corrected PTK and PMK lifetime handling 64f2a77 Cleared EAPOL temporary trace print's. 02ec23f Timed parent selection is now imim-imin*2 earlier there was just 5 seconds randomize. 3b2d906 Added check for network name and DODAG ID IID (EUI-64) (ARMmbed#2373) ee45f4b Updated initial key trickles 184425b Fixed parent target address set. 07ec237 Updated Discovery and RPL setup large & medium size network a94d8f2 RPL version num update 9e2ac1d Double default eapol entry size for test purpose. 6b8beef Clear all neighbors only on eapol next target check faa19e1 Corrected next address set 8a917fb Continue trickle on initial EAPOL-key TX failure cfdb193 Merge pull request ARMmbed#2368 from ARMmbed/sync_with_mbedos f7a15fa (via MbedOS) ws: added support for brazilian regulatory domain c397edb Changed large network initial-key trickle parameters 758f534 Added maximum frame counter storing interval b0ea148 Corrected key storage configuration setting be3c94e WS RPL paret soft filter update 8b1d537 Adjusted EAPOL limits and timers 9a21668 Merge branch 'release_internal' into release_external 8e72b80 MAC CCA thr: Check if channel out of range (ARMmbed#2363) 146a0a3 Corrected trace on authenticator d04a96d Merge pull request ARMmbed#2361 from ARMmbed/sync_with_mbedos 2c2b915 Added empty function for ns time callback 76ac0de Remove NCS36510 target 0258ac3 Remove KW24D target 788f01b Netsocket/lwIP Stack: Remove support for ARM Compiler 5 2fbc7a1 Corrected invalid memory read on access revoke 941b9b4 Updates to stagger/latency (ARMmbed#2358) c2abaaa Corrected defects 1811194 Corrected warning trace, validations and ut stubs 69e2d19 Added NS filesystem and interface to application c5b6993 refactored packet ingress a05605e Unsecured packets will be acked by default automatically. 36dfb29 MAC: Implemented automatic CCA threshold (ARMmbed#2353) 0396b97 Revert EAPOL simplify failure handling and focus this problem later on. b2fe3d4 Ignoring authentication failure if security protocol already started 11de56d Added info API for Wi-SUN border router 87a4f69 Added EAPOL key storage to authenticator and unified GTK storage (ARMmbed#2345) ff1ca25 EAPOL failure simplify and EAPOL relay agent add trace when eapol temp pool is empty 6667b31 Update NA trace 34cdafe Temporary EAPOL neighbour entry Update and MAC MLME update d092f83 Iotthd 3995 (ARMmbed#2347) e2ea4e4 Disabled BR (TLS server) EC calculation queue 5759851 Changed the rate limiting function to calculate the values runtime 899e755 Make it possible to update tr51 table to larger dynamically 8436669 Added configuration for DHCP lifetime value da732bc When network name or PAN ID is changed authenticator updates MAC keys git-subtree-dir: features/nanostack/sal-stack-nanostack git-subtree-split: b3fe574

Add the setting to use the mbed-os-example-client

5bf575a

By default, mbed-os-example-client can't be built for Renesas GR-PEACH, and This is the workaround for the issue.

bridadan reviewed Aug 8, 2016
View reviewed changes

Delete the unnecessary space.

08c084f

I deleted the unnecessary space.

TomoYamanaka reviewed Aug 9, 2016
View reviewed changes

0xc0170 added the needs: work label Aug 12, 2016

Modify "etropy_hardware_poll" function.

54abe29

In "etropy_hardware_poll" function, I modified to reference the API declared in us_ticker_api.h. And along the mbed OS 5.0 coding rules, I modified the code.

0xc0170 added needs: CI and removed needs: work labels Aug 25, 2016

0xc0170 added ready for merge and removed needs: CI labels Aug 26, 2016

sg- removed the ready for merge label Aug 26, 2016

sg- added the do not merge label Sep 8, 2016

sg- closed this Sep 28, 2016

Add the setting to use the mbed-os-example-client #2386

Add the setting to use the mbed-os-example-client #2386

Uh oh!

Conversation

TomoYamanaka commented Aug 8, 2016

Uh oh!

0xc0170 commented Aug 8, 2016

Uh oh!

bridadan Aug 8, 2016

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka Aug 9, 2016

Choose a reason for hiding this comment

Uh oh!

TomoYamanaka commented Aug 9, 2016

Uh oh!

0xc0170 commented Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomoYamanaka commented Aug 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomoYamanaka commented Aug 23, 2016

Uh oh!

0xc0170 commented Aug 25, 2016

Uh oh!

0xc0170 commented Aug 25, 2016

Uh oh!

mbed-bot commented Aug 25, 2016

Result: SUCCESS

Output

Uh oh!

sg- commented Aug 26, 2016

Uh oh!

TomoYamanaka commented Aug 29, 2016

Uh oh!

Osamu-Nakamura commented Sep 7, 2016

Uh oh!

sg- commented Sep 8, 2016

Uh oh!

toyowata commented Sep 16, 2016

Uh oh!

sg- commented Sep 28, 2016

Uh oh!

sg- commented Nov 11, 2016

Uh oh!

Osamu-Nakamura commented Nov 21, 2016

Uh oh!

Uh oh!

0xc0170 commented Aug 9, 2016 •

edited

Loading

TomoYamanaka commented Aug 10, 2016 •

edited

Loading