Skip to content

LWIP - fix recv blocking send on accepted sockets #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Aug 19, 2016

When a socket is created via accept set the mode to nonblocking -
a timeout of 1ms. This allows send and recv to occur at the same time.

When a socket is created via accept set the mode to nonblocking -
a timeout of 1ms. This allows send and recv to occur at the same time.
@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 19, 2016

/morph test

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 19, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=GCC_ARM
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 824]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 675

Test failed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 19, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 677

Test failed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 20, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 678

Test failed!

@tommikas
Copy link
Contributor

tommikas commented Aug 22, 2016

I think this should fix issue #2435 as well.

Edit: based on a quick test, it does.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2016

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2016

LGTM

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 680

Test failed!

@geky
Copy link
Contributor

geky commented Aug 22, 2016

It looks like the only failing test is the NIST issue again?

@bridadan has #2404 up to fix it, maybe this should wait until that pr is in?

@sg-
Copy link
Contributor

sg- commented Aug 23, 2016

/morph test

@sg- sg- added the needs: CI label Aug 23, 2016
@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 682

Test failed!

@geky
Copy link
Contributor

geky commented Aug 23, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 688

Test failed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 24, 2016

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 691

All builds and test passed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 24, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 692

Test failed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 24, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 693

Test failed!

@geky
Copy link
Contributor

geky commented Aug 24, 2016

One of the failures was due to a small bug in the nist test. This should be fixed over in this pr #2529

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 24, 2016

/morph test

1 similar comment
@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 24, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 702

Test failed!

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 703

All builds and test passed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 24, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 704

Test failed!

@c1728p9
Copy link
Contributor Author

c1728p9 commented Aug 24, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 706

Test failed!

@sg- sg- merged commit 2ecb560 into ARMmbed:master Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants