Fixed recvfrom address in ipv4 nist tests #2529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behaviours overwrote server address on failures
|
|
||
| printf("UDP: Recved from NTP server %d Bytes \n", n); | ||
|
|
||
| if (n > 0) { | ||
| if (n > 0 && source == nist) { |
There was a problem hiding this comment.
Potentially dumb question, but are you sure that the == comparison will do what you think it will here? I see that there currently isn't an explicit overloaded operator== in the SocketAddress class.
There was a problem hiding this comment.
Ah good catch! Entertaining this compiled just fine.
geky
force-pushed
the
fix-nsapi-nist-test
branch
from
2baef8f to
47018fe
Compare
|
+1 |
|
Awesome! Thanks @geky! /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 700 All builds and test passed! |
|
+1 from me! @sg- Good for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviours overwrote server address on failures, causing spurious failures during CI.
continuation of #2404
cc @bridadan