Skip to content

change NVIC_SystemReset to __NVIC_SystemReset #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

halazouna
Copy link

Change __STATIC_INLINE void NVIC_SystemReset(void) to __STATIC_INLINE void __NVIC_SystemReset(void) in core_cm3.h because of this PR

Change __STATIC_INLINE void NVIC_SystemReset(void) to __STATIC_INLINE void __NVIC_SystemReset(void) in core_cm3.h because of this PR ARMmbed/uvisor#334
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2016

Can you provide more details, why are you prefixing the function with __ and what does it solve? The referenced PR does not do any change like this, so might need more context.

@halazouna
Copy link
Author

halazouna commented Sep 21, 2016

I have add another modification, in case uVisor is not enabled.
Actually, when you enable uVisor, you have within the cmsis_nvic_virtual.h this define :
#define NVIC_SystemReset() vIRQ_SystemReset(RESET_REASON_NO_REASON)
which generates an error during the compilation.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2016

cc @AlessandroA

@AlessandroA
Copy link
Contributor

Hi @asensaoui thanks for this PR! I'd say this is superseded by #2774, which enables NVIC_SystemReset virtualization on all supported Cortex-M devices. See here. If you are happy with that commit, feel free to close this PR.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 23, 2016

@asensaoui Thanks for this patch. As mentioned above, the referenced PR is ready for merging, we will merge it soon. I'll close this PR

@0xc0170 0xc0170 closed this Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants