Virtualize NVIC_SystemReset #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since halt_error is going back to the former behavior of not returning, we could also restore the |
|
I don't see the reason for adding |
AlessandroA
force-pushed
the
virtualize_nvic_systemreset
branch
from
fd6efc6 to
a95808f
Compare
The `debug_halt_error` handler should not implicitly infer a reboot of the system. The debug box handler can reboot, if it thinks it's necessary. The newly introduced vIRQ_SystemReset API can be used for this purpose. By default, the debug handler will trigger a call to `uvisor_error`, a user-level API to trigger a halt. The halt will have the newly introduced reason `DEBUG_BOX_HALT`.
AlessandroA
force-pushed
the
virtualize_nvic_systemreset
branch
from
a95808f to
7907d36
Compare
halazouna
added a commit
to halazouna/mbed-os
that referenced
this pull request
Sep 21, 2016
Change __STATIC_INLINE void NVIC_SystemReset(void) to __STATIC_INLINE void __NVIC_SystemReset(void) in core_cm3.h because of this PR ARMmbed/uvisor#334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR virtualizes the
NVIC_SystemResetAPI.Upon merge, we need to update mbed OS and the version of CMSIS 5 it contains (there is a PR ready for that).
I'm also proposing the following change: The
halt_errorhandler in a debug box should not trigger a reset automatically, as it is counterintuitive. Instead, uVisor will halt upon return.The debug box can still call
NVIC_SystemResetif it wants to.@meriac @Patater @niklas-arm