[Tools] Handling Exceptions better when building tests #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result = False | ||
|
|
||
| if continue_on_build_fail: | ||
| continue | ||
| else: | ||
| break | ||
| else: | ||
| raise |
There was a problem hiding this comment.
This whole thing could also be:
except NotSupportedException:
pass
except ToolException:
result = False
if continue_on_build_fail:
continue
else:
breakThere was a problem hiding this comment.
That it could, and it is now so
bridadan
force-pushed
the
handle-exceptions-better
branch
from
5adb2f7 to
fa3257d
Compare
Previously, when building tests with test.py, if an exception occurred, the error message would be masked by the function 'build_tests'. This commit handles NotSupportedExceptions and ToolExceptions, but lets all other Exceptions propigate up to the caller function. In most cases, this is the CLI scripts, which will print a traceback. This will allow us to better debug the python tools if errors occur.
bridadan
force-pushed
the
handle-exceptions-better
branch
from
fa3257d to
cadcc80
Compare
theotherjimmy
approved these changes
Sep 28, 2016
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: null Examples Build failed! |
|
Oops this was my fault! Messing with CI again, retriggering now. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 993 All builds and test passed! |
|
@sg- Should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when building tests with
test.py, if an exception occurred, theerror message would be masked by the function 'build_tests'. This commit
handles
NotSupportedExceptions andToolExceptions, but lets all otherExceptions propigate up to the caller function. In most cases, this is the
CLI scripts, which will print a traceback. This will allow us to better
debug the python tools if errors occur.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos