Skip to content

[Tools] Handling Exceptions better when building tests #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tools/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -2106,14 +2106,14 @@ def build_tests(tests, base_source_paths, build_path, target, toolchain_name,
verbose=verbose,
app_config=app_config)

except Exception, e:
if not isinstance(e, NotSupportedException):
result = False

if continue_on_build_fail:
continue
else:
break
except NotSupportedException:
pass
except ToolException:
result = False
if continue_on_build_fail:
continue
else:
break

# If a clean build was carried out last time, disable it for the next build.
# Otherwise the previously built test will be deleted.
Expand Down